Skip to content

[Port 2.3-develop] Append shipment comment to shipment if appendComment is true #11519

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Oct 25, 2017
Merged

[Port 2.3-develop] Append shipment comment to shipment if appendComment is true #11519

merged 1 commit into from
Oct 25, 2017

Conversation

JeroenVanLeusden
Copy link
Member

Description

Add customer note to shipment if shipment is created with API and "appendComment" is set to true.

Fixed Issues (if relevant)

  1. Shipment API won't append comment to email #11207: Shipment API won't append comment to email

Manual testing scenarios

  1. Place an order via the website.
  2. Create a shipment using the API with "appendComment": true.
  3. Add comment to the shipment in same request.
  4. Shipment email is being send with comment appended.

Contribution checklist

  • Pull request has a meaningful description of its purpose
  • All commits are accompanied by meaningful commit messages
  • All new or changed code is covered with unit/integration tests (if applicable)
  • All automated tests passed successfully (all builds on Travis CI are green)

@ishakhsuvarov ishakhsuvarov self-assigned this Oct 18, 2017
@ishakhsuvarov ishakhsuvarov added this to the October 2017 milestone Oct 18, 2017
@ishakhsuvarov ishakhsuvarov added Release Line: 2.3 2.2.x Fixed in 2.2.x The issue has been fixed in 2.2 release line Reproduced on 2.1.x The issue has been reproduced on latest 2.1 release Reproduced on 2.2.x The issue has been reproduced on latest 2.2 release Reproduced on 2.3.x The issue has been reproduced on latest 2.3 release labels Oct 18, 2017
@ishakhsuvarov ishakhsuvarov mentioned this pull request Oct 19, 2017
Closed
4 tasks
@okorshenko okorshenko merged commit 70f3e2a into magento:2.3-develop Oct 25, 2017
okorshenko pushed a commit that referenced this pull request Oct 25, 2017
@ishakhsuvarov
MAGETWO-82187: [Port 2.3-develop] Append shipment comment to shipment…
f24ce2e 
… if appendComment is true #11519
@JeroenVanLeusden JeroenVanLeusden deleted the patch-7 branch December 4, 2017 15:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@ishakhsuvarov ishakhsuvarov

Labels
Award: test coverage Fixed in 2.2.x The issue has been fixed in 2.2 release line Progress: accept Release Line: 2.3 Reproduced on 2.1.x The issue has been reproduced on latest 2.1 release Reproduced on 2.2.x The issue has been reproduced on latest 2.2 release Reproduced on 2.3.x The issue has been reproduced on latest 2.3 release
Projects
None yet
Milestone
October 2017
Development

Successfully merging this pull request may close these issues.
5 participants
@JeroenVanLeusden @magento-team @vkublytskyi @ishakhsuvarov @okorshenko