9007: Get MAGETWO-52856 into Magento 2.1.x #11640
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
ishakhsuvarov
requested changes
Oct 23, 2017
| * @return \Magento\Quote\Api\CartRepositoryInterface | ||
| * @deprecated | ||
| */ | ||
| private function getCartRepository() |
There was a problem hiding this comment.
Please try injecting this dependency as an optional constructor argument. Please refer to Backwards Compatible Development Guide for more information
There was a problem hiding this comment.
@ishakhsuvarov Done.
nmalevanec
changed the title
okorshenko
pushed a commit
that referenced
this pull request
Oct 27, 2017
okorshenko
pushed a commit
that referenced
this pull request
Oct 27, 2017
[EngCom] Public Pull Requests - 2.1-develop - MAGETWO-82527: Backport MAGETWO-52856 into Magento 2.1.x #11640
elioermini
reviewed
Mar 1, 2018
| ) { | ||
| $this->billingAddressManagement = $billingAddressManagement; | ||
| $this->paymentMethodManagement = $paymentMethodManagement; | ||
| $this->cartManagement = $cartManagement; | ||
| $this->paymentDetailsFactory = $paymentDetailsFactory; | ||
| $this->cartTotalsRepository = $cartTotalsRepository; | ||
| $this->cartRepository = $cartRepository ? : \Magento\Framework\App\ObjectManager::getInstance() |
There was a problem hiding this comment.
Why using the object manager in the constructor?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Backport MAGETWO-52856 from 2.2.0 to 2.1 - develop
Description
Provide seamless experience on checkout with large amount of customer addresses.
Fixed Issues (if relevant)
Manual testing scenarios
Contribution checklist