Skip to content

Add validation for number of street lines [Backport 2.1] #12022

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Nov 6, 2017
Merged

Add validation for number of street lines [Backport 2.1] #12022

merged 1 commit into from
Nov 6, 2017
+2 −1

Conversation

crissanclick
Copy link
Contributor

Description

Shipping address lines dissapear when street_lines on customer configuration is set to 0.

Fixed Issues (if relevant)

  1. If you leave as default, shipping lines disappear #7995

Manual testing scenarios

  1. Go to Stores > Configuration > Customer > Customer Configuration
  2. Set Number of Lines in a Street Address to 0

Contribution checklist

  • Pull request has a meaningful description of its purpose
  • All commits are accompanied by meaningful commit messages
  • All new or changed code is covered with unit/integration tests (if applicable)
  • All automated tests passed successfully (all builds on Travis CI are green)

@vrann vrann added the mm17es label Nov 5, 2017
@vrann vrann self-assigned this Nov 5, 2017
@vrann vrann added this to the November 2017 milestone Nov 5, 2017
@vrann vrann added Release Line: 2.1 2.2.x bug report Component: Checkout Component: Config Reproduced on 2.1.x The issue has been reproduced on latest 2.1 release Reproduced on 2.2.x The issue has been reproduced on latest 2.2 release Reproduced on 2.3.x The issue has been reproduced on latest 2.3 release labels Nov 5, 2017
@vkublytskyi vkublytskyi self-assigned this Nov 5, 2017
@magento-team magento-team merged commit 6d4a93f into magento:2.1-develop Nov 6, 2017
magento-team pushed a commit that referenced this pull request Nov 6, 2017
@ishakhsuvarov
MAGETWO-83284: Add validation for number of street lines [Backport 2.1]
93f7e25 
#12022
magento-team pushed a commit that referenced this pull request Nov 6, 2017
@ishakhsuvarov
Merge pull request #1665 from magento-engcom/2.1-develop-prs
8ffe3cc 
[EngCom] Public Pull Requests - 2.1-develop
 - MAGETWO-83284: Add validation for number of street lines [Backport 2.1] #12022
 - MAGETWO-83205: Check attribute unique between same fields in magento commerce [backport 2.1] #11621
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@vkublytskyi vkublytskyi

@vrann vrann

Labels
bug report Component: Checkout Component: Config Progress: accept Release Line: 2.1 Reproduced on 2.1.x The issue has been reproduced on latest 2.1 release Reproduced on 2.2.x The issue has been reproduced on latest 2.2 release Reproduced on 2.3.x The issue has been reproduced on latest 2.3 release
Projects
None yet
Milestone
November 2017
Development

Successfully merging this pull request may close these issues.
4 participants
@crissanclick @magento-team @vkublytskyi @vrann