Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[2.2-develop] Fixes #12660 invalid parameter configuration provided for argument #12661

Merged
merged 1 commit into from
Dec 13, 2017

Conversation

Tomasz-Silpion
Copy link
Member

Description

In clean Magento 2.2.0, 2.2.1, 2.2.2 Invalid parameter configuration provided for $block argument of Magento\\Ui\\Component\\HtmlContent exception is thrown for admin role restricted to customer management with no ACL permissions to newsletter or sales tab

Fixed Issues (if relevant)

  1. Invalid parameter configuration provided for $block argument upon no ACL permissions to the block #12660: Invalid parameter configuration provided for $block argument upon no ACL permissions to the block
  2. ACL permissions issue #12452: ACL permissions issue

Manual testing scenarios

  1. Create new admin user role with customer tab permissions only
  2. Assign new admin user to the role
  3. Login as the user
  4. Try to create new customer

Contribution checklist

  • Pull request has a meaningful description of its purpose
  • All commits are accompanied by meaningful commit messages
  • All new or changed code is covered with unit/integration tests (if applicable)
  • All automated tests passed successfully (all builds on Travis CI are green)

@magento-engcom-team magento-engcom-team added Reproduced on 2.2.x The issue has been reproduced on latest 2.2 release Reproduced on 2.3.x The issue has been reproduced on latest 2.3 release labels Dec 13, 2017
@osrecio
Copy link
Member

osrecio commented Dec 13, 2017

Hi @Tomasz-Silpion Thanks for you contribution!

Can you check failing test, exactly this

@Tomasz-Silpion Tomasz-Silpion changed the title Fixes #12660 invalid parameter configuration provided for argument [2.2-develop] Fixes #12660 invalid parameter configuration provided for argument Dec 13, 2017
@magento-team magento-team merged commit c7abab1 into magento:2.2-develop Dec 13, 2017
magento-team pushed a commit that referenced this pull request Dec 13, 2017
magento-team pushed a commit that referenced this pull request Dec 13, 2017
[EngCom] Public Pull Requests - 2.2-develop
 - MAGETWO-85583: #12378: Regions list in Directory module for India #1007
 - MAGETWO-85580: Fixes #12660 invalid parameter configuration provided for argument #12661
 - MAGETWO-85534: #8647: [GitHub] Order of how arguments are merged in multiple di.xml-… #995
 - MAGETWO-84370: 11946: Layer navigation showing wrong product count #12063
Fixed issues:
 - #12378 Regions list in Directory module for India
 - #12452 ACL permissions issue
 - #12660 Invalid parameter configuration provided for $block argument upon no ACL permissions to the block
 - #8647 Order of how arguments are merged in multiple di.xml-files causes unexpected results
 - #11946 Layer navigation showing wrong product count
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Progress: accept Release Line: 2.2 Reproduced on 2.2.x The issue has been reproduced on latest 2.2 release Reproduced on 2.3.x The issue has been reproduced on latest 2.3 release
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants