Add more parameters to ajax:addToCart #12875
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The SKU by itself is not very useful because for most third-party integration you will need at minimum SKU and qty. The 'res' is also important because you could write a plugin for Magento\Checkout\Controller\Cart\Add to add more information to the return JSON.
|
Would be handy if this was backported to 2.1 too :) |
|
However after looking at other places Magento fires events through the trigger, I'm not a fan of dumping all the parameters after each other in the trigger. It would be better to add 1 parameter 'eventData' that contains the seperate variables. |
4 tasks
Merged
4 tasks
|
Created Backport for this #14898 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
The SKU by itself is not very useful because for most third-party integration you will need at minimum SKU and qty.
The 'res' is also important because you could write a plugin for Magento\Checkout\Controller\Cart\Add to add more information to the return JSON.