Skip to content

Conversation

koenner01
Copy link
Contributor

@koenner01 koenner01 commented Feb 23, 2018

Description

When submitting the search form (mini) with an empty value, an error is throw on preventDefault

Fixed Issues (if relevant)

  1. Submitting search form (mini) with empty value throws error on preventDefault #13791

Manual testing scenarios

  1. See description and testing scenario in original issue Submitting search form (mini) with empty value throws error on preventDefault #13791

Contribution checklist

  • Pull request has a meaningful description of its purpose
  • All commits are accompanied by meaningful commit messages
  • All new or changed code is covered with unit/integration tests (if applicable)
  • All automated tests passed successfully (all builds on Travis CI are green)

@magento-engcom-team magento-engcom-team added this to the February 2018 milestone Feb 24, 2018
@magento-engcom-team
Copy link
Contributor

Hi @mzeis, thank you for the review.
MAGETWO-88331 has been created to process this Pull Request

@magento-engcom-team
Copy link
Contributor

@koenner01 thank you for contributing. Please accept Community Contributors team invitation here to gain extended permissions for this repository.

@mzeis
Copy link
Contributor

mzeis commented Feb 24, 2018

Hi @koenner01! Thank you very much for your contribution. Your PR fixes the issue for me.

@mzeis
Copy link
Contributor

mzeis commented Feb 27, 2018

Hi @koenner01, thanks again for your PR! It has been merged into 2.2-develop.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants