magento/magento2#12405: Impossible to create a new storeview #13943
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Magento_Config should depend on Magento_Store
|
Hi @hostep I will try to get some more information on the best way to do this for you. If you look at say the customer module it requires a specific store module version in the composer.json but the module xml does not set the sequence. |
|
Ok thanks. My question is if we fix this issue by adding the module in the sequence, if this is the correct fix, or if this will only hide the real problem? |
|
Hi @hostep so looking into the debugging of the issue. I can see that there seems to be two deprecated sections of the code being called in the flow. The first is in the The second is in the In both cases I am not actually sure if making these changes would actually fix this problem or would we still have the same problem but now with refactored code. Did you have any experience with these parts in the code base? |
|
Thanks @dmanners for the further investigation! (I really need to start learning how to use PhpStorm properly, but I love Sublime so much :p) Anyways, I also don't know if those two deprecated method calls cause this problem, I doubt it, but no experience there I'm afraid. My guess is that by changing the sequence of the module load order, that certain functionality is executed in a slightly different order then otherwise, but I don't know which functionality that could be or how to try to debug this somehow... |
|
Hi @hostep looking into other modules with similar issues I feel that this is an acceptable solution. Thanks for this PR. |
This was referenced Mar 8, 2018
magento-team
pushed a commit
that referenced
this pull request
Mar 8, 2018
|
Ok excellent, thanks @dmanners! |
|
I quickly tested this on the One interesting thing is that this problem throws a different error on |
4 tasks
|
@hostep Does anything in this topic need to be changed as a result of your PR? https://devdocs.magento.com/guides/v2.2/extension-dev-guide/build/module-load-order.html |
4 tasks
|
@keharper: I don't think so. Looks pretty good, but I'm no expert for those things. But honestly, I have not idea why this change was necessary. Someone should do a deep dive in the code to figure out why the order of execution caused this problem, because this PR is probably only hiding a deeper problem. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This is a retake of #12407, but with only a single dependency added.
I'm still not exactly sure if this is the right way to solve this, but nobody seems to give feedback in the original issue, so I'm trying it again with a PR.
Fixed Issues (if relevant)
Manual testing scenarios
app/etc/config.phpand move the line'Magento_Config' => 1,higher up the list then'Magento_Store' => 1,(normally you shouldn't do this manually, but installing certain 3rd party modules give the same as a result)Requested store is not foundis shown and no storeview is added.By defining
Magento_Storeas a dependency ofMagento_Configwe make sure that this sort order of modules outlined in step 2 can never happen.Contribution checklist