[Forwardport] Modify Report processor to return 500 #14190
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The report processor is currently returning a HTTP 503 status code; generally used for temporarily failures to connect to a service such as when that service is in maintenance mode, when an upstream proxy is unavailable etc. This commit modifies the report HTTP code to be a 500. The author believes this to be a better reflection that the error is miscellaneous in nature, and that action is required in order to change it (i.e. it is not a temporary condition)
|
|
|
@AlexWorking thank you for contributing. Please accept Community Contributors team invitation here to gain extended permissions for this repository. |
orlangur
approved these changes
Mar 21, 2018
|
Hi @orlangur, thank you for the review. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Original Pull Request
#11513
The report processor is currently returning a HTTP 503 status
code; generally used for temporarily failures to connect to a service
such as when that service is in maintenance mode, when an upstream
proxy is unavailable etc.
This commit modifies the report HTTP code to be a 500. The author
believes this to be a better reflection that the error is miscellaneous
in nature, and that action is required in order to change it (i.e.
it is not a temporary condition)
Fixes #11512