[Forwardport] Disable "Back" button on the first step of the setup #14460
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 2 commits
March 30, 2018 08:31
When you enter the setup of Magento, the "Back" button is enabled on the first step. When you click this, you go straight to the final step of the installation, without entering any data in the steps, so you can't install Magento at all. With this commit the back button on the first step of the setup is always disabled, since there's no previous step, except for the page where you agree with the terms and conditions, which is not part of the wizard.
The "goToStart" method was used for the "Back" button on the first step, but since that button is disabled now, the method is no longer used within Magento. Therefore it is removed from the codebase now.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Original Pull Request
#14309
Description
When you enter the setup of Magento, the "Back" button is enabled
on the first step. When you click this, you go straight to the
final step of the installation, without entering any data in the
steps, so you can't install Magento at all.
With this commit the back button on the first step of the setup
is always disabled, since there's no previous step, except for the
page where you agree with the terms and conditions, which is not
part of the wizard.
Fixed Issues
Manual testing scenarios
Contribution checklist