Skip to content

Check if store id is not null instead of empty #14504

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Apr 4, 2018
Merged

Check if store id is not null instead of empty #14504

merged 1 commit into from
Apr 4, 2018

Conversation

quisse
Copy link

@quisse quisse commented Apr 3, 2018 •
edited
Loading

Description

Store id 0 is_empty returns true so a cms page for all store views can’t be created

Contribution checklist

  • Pull request has a meaningful description of its purpose
  • All commits are accompanied by meaningful commit messages
  • All new or changed code is covered with unit/integration tests (if applicable)
  • All automated tests passed successfully (all builds on Travis CI are green)

Check if store id is not null instead of empty
7836669 
Store id 0 is empty returns true so a cms page for all store views can’t be created
@magento-engcom-team magento-engcom-team added this to the April 2018 milestone Apr 3, 2018
@quisse quisse self-assigned this Apr 3, 2018
magento-team pushed a commit that referenced this pull request Apr 4, 2018
ENGCOM-1222: Check if store id is not null instead of empty #14504
6dd9e6e
@magento-engcom-team magento-engcom-team merged commit 7836669 into magento:2.2-develop Apr 4, 2018
@namlier namlier mentioned this pull request Apr 4, 2018
Merged
4 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@sidolov sidolov

Labels
Progress: accept Release Line: 2.2
Projects
None yet
Milestone
April 2018
Development

Successfully merging this pull request may close these issues.
3 participants
@quisse @sidolov @magento-engcom-team