Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Forwardport] Removed unused class declaration and code #15185

Merged
merged 1 commit into from May 17, 2018
Merged

[Forwardport] Removed unused class declaration and code #15185

merged 1 commit into from May 17, 2018

Conversation

dmytro-ch
Copy link
Contributor

@dmytro-ch dmytro-ch commented May 13, 2018 •
edited by sidolov

Original PR: #15173

Description

Removed unused class declaration from controller's index action
Removed unused the code in the comment block from the template file.

Fixed Issues (if relevant)

Removed unused class declaration and code

Manual testing scenarios

  1. N/A

Contribution checklist

  • Pull request has a meaningful description of its purpose
  • All commits are accompanied by meaningful commit messages
  • All new or changed code is covered with unit/integration tests (if applicable)
  • All automated tests passed successfully (all builds on Travis CI are green)

@dmytro-ch dmytro-ch added Release Line: 2.3 partners-contribution Pull Request is created by Magento Partner Partner: Atwix Pull Request is created by partner Atwix labels May 13, 2018
@dmytro-ch dmytro-ch requested a review from rogyar May 13, 2018 17:06
@magento-engcom-team magento-engcom-team added this to the May 2018 milestone May 13, 2018
@magento-engcom-team
Copy link
Contributor

Hi @rogyar, thank you for the review.
ENGCOM-1545 has been created to process this Pull Request

@magento-engcom-team magento-engcom-team merged commit e3e8738 into magento:2.3-develop May 17, 2018
magento-engcom-team pushed a commit that referenced this pull request May 17, 2018
@VladimirZaets
ENGCOM-1545: [Forwardport] Removed unused class declaration and code #…
e106261 
…15185
@magento-engcom-team
Copy link
Contributor

Hi @dmytro-ch. Thank you for your contribution.
Changes from your Pull Request will be available with the upcoming 2.3.0 release.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rogyar rogyar rogyar approved these changes

Assignees

@rogyar rogyar

Labels
Partner: Atwix Pull Request is created by partner Atwix partners-contribution Pull Request is created by Magento Partner Progress: accept Release Line: 2.3
Projects
None yet
Milestone
May 2018
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@dmytro-ch @magento-engcom-team @rogyar