Fixes in InstantPurchase #15257
Merged
Fixes in InstantPurchase #15257
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 5 commits
May 16, 2018 12:46
…ase\Model\AddressIn as its type.
|
Hi @mhauri. Thank you for your contribution. |
magento-engcom-team
added a commit
that referenced
this pull request
May 25, 2018
magento-engcom-team
pushed a commit
that referenced
this pull request
May 25, 2018
magento-engcom-team
pushed a commit
that referenced
this pull request
May 25, 2018
Accepted Public Pull Requests: - #15460: Improvements to the CONTRIBUTING.md document (by @RebeccaBrocton) - #15421: Updated font-size variable and standardize #ToDo UI (by @vgelani) - #15422: Refactor JavsScript for UrlRewrite module edit page (by @patelnimesh1988) - #15435: [Backport] Removed redundant else statement (by @rogyar) - #15409: Prevent multiple add-to-cart initializations in case of ajax loaded product listing (by @vovayatsyuk) - #15211: Error 500 in Module Manager (by @flancer64) - #15340: Submitting search form (mini) with enter key fires event handlers bound by jquery twice (by @amjadm61) - #15364: Added language translation for comment tag (by @yogeshks) - #15371: Added language translation in template files (by @rahul-kachhadiya) - #15258: [backport] fixes for instant purchase module from #15257 (by @mhauri) - #15010: [BUGFIX] Added row_id to the flat action indexer so the value isn't s� (by @lewisvoncken) Fixed GitHub Issues: - #15356: Refactore javascript for module URL rewrite (reported by @vgelani) has been fixed in #15422 by @patelnimesh1988 in 2.2-develop branch Related commits: 1. 28642a6 - #15192: Module Manager module grid is not working Magento 2.2.4 (reported by @jignesh-baldha) has been fixed in #15211 by @flancer64 in 2.2-develop branch Related commits: 1. a95034a 2. 131a458 - #13793: Submitting search form (mini) with enter key fires event handlers bound by jquery twice (reported by @koenner01) has been fixed in #15340 by @amjadm61 in 2.2-develop branch Related commits: 1. 153faa6 - #15361: Comments are not translated for Signifyd module. (reported by @yogeshks) has been fixed in #15364 by @yogeshks in 2.2-develop branch Related commits: 1. f295906
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
The Method
get($type)in/Magento/InstantPurchase/Model/ShippingMethodChoose/DeferredShippingMethodChooserPool.phpthrows an Exception without showing the shipping method $type as it was hardcoded as'chooser'.Allowing
nullfor properties inInstantPurchaseOption.phpas they are null in the constructor by default.Fixing PHPDocs as they refer to wrong Classes or have missing type declarations.
Contribution checklist