Skip to content

[fix] typo in method name _exportAddress[s]es #15275

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
May 22, 2018
Merged

[fix] typo in method name _exportAddress[s]es #15275

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
b2318bb
[fix] typo in method name from Nvp class
May 17, 2018
1a0c8e5
[task] add deprecated notice to misspelled method
May 18, 2018
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
15 changes: 14 additions & 1 deletion app/code/Magento/Paypal/Model/Api/Nvp.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -846,7 +846,7 @@ public function callGetExpressCheckoutDetails()
$request = $this->_exportToRequest($this->_getExpressCheckoutDetailsRequest);
$response = $this->call(self::GET_EXPRESS_CHECKOUT_DETAILS, $request);
$this->_importFromResponse($this->_paymentInformationResponse, $response);
$this->_exportAddressses($response);
$this->_exportAddresses($response);
}

/**
Expand Down Expand Up @@ -1463,8 +1463,21 @@ protected function _exportLineItems(array &$request, $i = 0)
*
* @param array $data
* @return void
* @deprecated 100.2.2 typo in method name
* @see _exportAddresses
*/
protected function _exportAddressses($data)
{
$this->_exportAddresses($data);
}

/**
* Create billing and shipping addresses basing on response data
*
* @param array $data
* @return void
*/
protected function _exportAddresses($data)
{
$address = new \Magento\Framework\DataObject();
\Magento\Framework\DataObject\Mapper::accumulateByMap($data, $address, $this->_billingAddressMap);
Expand Down