Skip to content

Conversation

saravananvelu
Copy link
Contributor

Resolved product tier price pagination loader issue in admin

Description:

Navigate Admin => Catalog => Products => Create New / Edit Product.

  1. Go to Advanced Pricing link under Price text field.
  2. Add tier price more than a page and do save.
  3. Jump to other pages by directly editing the pagination text box.

Fixed Issues (if relevant)

  1. Advanced pricing pagination issue #15210: Advanced pricing pagination issue

@magento-cicd2
Copy link
Contributor

magento-cicd2 commented May 19, 2018

CLA assistant check
All committers have signed the CLA.

@sidolov
Copy link
Contributor

sidolov commented May 20, 2018

Hi @saravananvelu , please, sign CLA, otherwise, we can't process your pull request.

@magento-engcom-team
Copy link
Contributor

@saravananvelu thank you for contributing. Please accept Community Contributors team invitation here to gain extended permissions for this repository.

changePage: function (page) {
this.clear();

if (page === 1 && !this.recordData().length) {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @saravananvelu. Thanks for the collaboration.
This issue reproduced in all places where dynamic-rows component is used, so will be great if you fix this issue in the more general way, in the parent class.

Also, you can call the method from the parent class (this._super()) instead of copy-paste it

Copy link
Contributor Author

@saravananvelu saravananvelu May 24, 2018

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I have updated the code in parent class and removed the same from child class

saravananvelu and others added 2 commits May 23, 2018 18:11
- Fix prevPage and nextPage method. Calling clear method was added to changePage method.
@VladimirZaets
Copy link
Contributor

Hi @saravananvelu, thanks!
Also, I removed calling the clear method inside previous and next page method. Currently, it will be redundant.

@magento-engcom-team
Copy link
Contributor

Hi @saravananvelu. Thank you for your contribution.
Changes from your Pull Request will be available with the upcoming 2.3.0 release.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants