-
Notifications
You must be signed in to change notification settings - Fork 9.4k
15210-Fixed product tier pricing pagination issue in admin #15360
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
15210-Fixed product tier pricing pagination issue in admin #15360
Conversation
Hi @saravananvelu , please, sign CLA, otherwise, we can't process your pull request. |
@saravananvelu thank you for contributing. Please accept Community Contributors team invitation here to gain extended permissions for this repository. |
changePage: function (page) { | ||
this.clear(); | ||
|
||
if (page === 1 && !this.recordData().length) { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hi @saravananvelu. Thanks for the collaboration.
This issue reproduced in all places where dynamic-rows component is used, so will be great if you fix this issue in the more general way, in the parent class.
Also, you can call the method from the parent class (this._super()
) instead of copy-paste it
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I have updated the code in parent class and removed the same from child class
- Fix prevPage and nextPage method. Calling clear method was added to changePage method.
Hi @saravananvelu, thanks! |
Hi @saravananvelu. Thank you for your contribution. |
Resolved product tier price pagination loader issue in admin
Description:
Navigate Admin => Catalog => Products => Create New / Edit Product.
Fixed Issues (if relevant)