issue fixed #8258 - assign indices for all array inputs so that validation works properly

[jayankaghosh]

Form validation with identical field names does not work as expected

Description

Assign indices to array inputs and later remove them before submitting as a workaround for the validation library to work properly.

Fixed Issues (if relevant)

1. M2.1.3 : Form validation with identical field names does not work as expected. #8258 Form validation with identical field names does not work as expected

Manual testing scenarios

1. Create a form with identical fields and add JavaScript validation
2. Submit the form with improper values in fields.
3. Validation should work properly now

[VladimirZaets]

Hi @jayankaghosh , thanks for fixes.

[gautamkrishnar]

Awesome

[jayankaghosh]

Oh didn't follow on this for a long time. So this is fixed now? Cool!
P.S I can see the Travis CI failed due to code standard not being proper. So does that need to be reworked on?

[jayankaghosh]

@VasylShvorak This issue is resolved now.
The only drawback is, if the mage/validation plugin is used on a form, no other form submit listeners should be attached to the form, or, a submitHandler has to be explicitly mentioned where the further form submit listeners need to be specified.
I believe this is a very particular and rare scenario and should not happen that often. It should work with all existing Magento's forms which are using the mage/validation

[magento-engcom-team]

Hi @VladimirZaets, thank you for the review.
ENGCOM-5174 has been created to process this Pull Request

[VasylShvorak]

✔️ QA passed

[magento-cicd2]

Thank you for your submission, we really appreciate it. Like many open source projects, we ask that you all sign our Contributor License Agreement before we can accept your contribution.
3 out of 4 committers have signed the CLA.

✅ jayankaghosh
✅ VladimirZaets
✅ p-bystritsky
❌ ysapiga

[magento-cicd2]

Thank you for your submission, we really appreciate it. Like many open source projects, we ask that you all sign our Contributor License Agreement before we can accept your contribution.
3 out of 4 committers have signed the CLA.

✅ jayankaghosh
✅ VladimirZaets
✅ p-bystritsky
❌ ysapiga

[m2-assistant]

Hi @jayankaghosh, thank you for your contribution!
Please, complete Contribution Survey, it will take less than a minute.
Your feedback will help us to improve contribution process.