Skip to content

Fixes in config module #15511

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
May 25, 2018
Merged

Fixes in config module #15511

merged 2 commits into from
May 25, 2018

Conversation

mhauri
Copy link

@mhauri mhauri commented May 25, 2018 •
edited
Loading

Description

This PR fixes two issues in the Magento/Config Module:

  1. The method Magento/Config/Test/Unit/Block/System/Config/Form/Field/ImageTest.php::testGetElementHtmlWithValue() references to a invalid Backend Model on line 77

  2. The anonymous function has an unused use $data in Magento/Config/Model/Config/Importer.php on line 127

Contribution checklist

  • Pull request has a meaningful description of its purpose
  • All commits are accompanied by meaningful commit messages
  • All new or changed code is covered with unit/integration tests (if applicable)
  • All automated tests passed successfully (all builds on Travis CI are green)

@magento-engcom-team magento-engcom-team added this to the Release: 2.2.5 milestone May 25, 2018
@magento-engcom-team magento-engcom-team merged commit 8c68d6b into magento:2.2-develop May 25, 2018
magento-engcom-team pushed a commit that referenced this pull request May 25, 2018
ENGCOM-1673: Fixes in config module #15511
1986568
@magento-engcom-team
Copy link
Contributor

Hi @mhauri. Thank you for your contribution.
Changes from your Pull Request will be available with the upcoming 2.2.5 release.

Please, consider porting this solution across release lines.
You may use Porting tool to port commits automatically.

@mhauri mhauri mentioned this pull request Jun 1, 2018
Merged
4 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@sidolov sidolov

Labels
Component: Config Progress: accept Release Line: 2.2
Projects
None yet
Milestone
Release: 2.2.5
Development

Successfully merging this pull request may close these issues.
3 participants
@mhauri @magento-engcom-team @sidolov