Skip to content

[Forwardport] Improvements to the CONTRIBUTING.md document #15520

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
May 30, 2018
Merged

[Forwardport] Improvements to the CONTRIBUTING.md document #15520

merged 1 commit into from
May 30, 2018

Conversation

osrecio
Copy link
Member

@osrecio osrecio commented May 25, 2018

Original Pull Request

#15460

Description

Wording changes & link updates to CONTRIBUTING.md.

Contribution checklist

  • Pull request has a meaningful description of its purpose
  • All commits are accompanied by meaningful commit messages
  • All new or changed code is covered with unit/integration tests (if applicable)
  • All automated tests passed successfully (all builds on Travis CI are green)

@miguelbalparda miguelbalparda self-assigned this May 26, 2018
@magento-engcom-team magento-engcom-team added this to the Release: 2.3.0 milestone May 26, 2018
@magento-engcom-team magento-engcom-team added Partner: Interactiv4 Pull Request is created by partner Interactiv4 partners-contribution Pull Request is created by Magento Partner labels May 26, 2018
@magento-engcom-team
Copy link
Contributor

Hi @miguelbalparda, thank you for the review.
ENGCOM-1687 has been created to process this Pull Request

@magento-engcom-team magento-engcom-team merged commit 9787807 into magento:2.3-develop May 30, 2018
magento-engcom-team pushed a commit that referenced this pull request May 30, 2018
ENGCOM-1687: [Forwardport] Improvements to the CONTRIBUTING.md document
6c3eb8c 
#15520
@magento-engcom-team
Copy link
Contributor

Hi @osrecio. Thank you for your contribution.
Changes from your Pull Request will be available with the upcoming 2.3.0 release.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@miguelbalparda miguelbalparda miguelbalparda approved these changes

Assignees

@miguelbalparda miguelbalparda

Labels
Partner: Interactiv4 Pull Request is created by partner Interactiv4 partners-contribution Pull Request is created by Magento Partner Progress: accept Release Line: 2.3
Projects
None yet
Milestone
Release: 2.3.0
Development

Successfully merging this pull request may close these issues.
4 participants
@osrecio @magento-engcom-team @miguelbalparda @RebeccaBrocton