Skip to content

Bringing menu items to one style - plural #1579

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 3 commits into from
Closed

Bringing menu items to one style - plural #1579

wants to merge 3 commits into from

Conversation

nja78
Copy link

@nja78 nja78 commented Jul 29, 2015

While translating have noticed that menu items styles differs.
Example for Marketing -> Promotions:
current

  • Catalog Price Rule
  • Cart Price Rules

new

  • Catalog Price Rules
  • Cart Price Rules

Same for acl titles and main grid.

@vpelipenko vpelipenko added the MX label Jul 29, 2015
@kokoc kokoc added the PROD label Aug 4, 2015
@magento-cicd2
Copy link
Contributor

We have automated a Magento Contributor License Agreement verifier for contributions sent to our GitHub projects.
Please see the CLA agreement in the Pull Request comments.

@magento-cicd2 magento-cicd2 reopened this Oct 1, 2015
@vzabaznov
Copy link
Contributor

@nja78 thank you for contributing, please could you update your code and resolve conflicts

@KrystynaKabannyk
Copy link

The internal ticket is created MAGETWO-50776.

@vasiliyseleznev vasiliyseleznev removed the MX label Aug 2, 2016
@vkorotun vkorotun added Issue: Ready for Work Gate 4. Acknowledged. Issue is added to backlog and ready for development and removed Issue: Ready for Work Gate 4. Acknowledged. Issue is added to backlog and ready for development labels Aug 4, 2016
@vkorotun vkorotun added Issue: Ready for Work Gate 4. Acknowledged. Issue is added to backlog and ready for development and removed linked labels Aug 22, 2016
@vrann vrann self-assigned this Mar 22, 2017
@vrann vrann added this to the March 2017 milestone Mar 22, 2017
@vrann
Copy link
Contributor

vrann commented Mar 22, 2017

@nja78 While this is a good change, I have concerns accepting it. String literals translated via __() is a subject of backward compatibility rules, because translation packages depend on the exact value of the string. Having little severance of this issue but the potential damage to translation packages, I would reject it.

But regardless, thank you for participation in the Magento community!

@vrann vrann closed this Mar 22, 2017
magento-team pushed a commit that referenced this pull request Oct 11, 2017
Merge pull request #1579 from magento-engcom/develop-prs
45d1d93 
Public Pull Requests

#11234
#11086
#11073
#11092
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@vrann vrann

Labels
Component: Customer improvement Issue: Ready for Work Gate 4. Acknowledged. Issue is added to backlog and ready for development Progress: reject
Projects
None yet
Milestone
March 2017
Development

Successfully merging this pull request may close these issues.
10 participants
@nja78 @magento-cicd2 @vzabaznov @KrystynaKabannyk @vrann @kokoc @voleye @vpelipenko @vasiliyseleznev @vkorotun