-
Notifications
You must be signed in to change notification settings - Fork 9.4k
Eliminate the need for inheritance for action controllers. #16268
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
…action interface plugin See magento/community-features#9 for further information.
…to ActionInterface::execute
…xecute because bc does not allow it
…develop branch to the 2.3-develop branch
Hi @Vinai. Thank you for your contribution
For more details, please, review the Magento Contributor Assistant documentation |
@Vinai not sure what happened with this one, but we cannot process PR from an |
Hi @Vinai, thank you for your contribution! |
Interesting, no idea either. I hope I can do that. |
Just to wrap this up, I'll won't be picking this PR up again. I think it's futile without access to EE and B2B repos. |
Description
Kindly see issue magento/community-features#9 for detailed information.
Fixed Issues (if relevant)
All the CE unit and integration tests pass. The big question is how the EE will do.
When this PR is merged, frontend action controllers don't have to extend AbstractAction, they only have to implement the ActionInterface.
This PR mainly moves the dispatching of the controller_predispatch events into a plugin.
It also changes the plugins for
Action::dispatch()
method toActionInterface::execute()
.Finally, it preserves the behavior in regards to the
NO_DISPATCH
andNO_POST_DISPATCH
action flags.Backend action controllers still have to extend the backend module abstract Action for authentication - moving that to a plugin will be a separate PR.
NOTE:
This PR is a port of #13045 to the 2.3-develop branch as discussed with @sidolov
The PR to the 2.2-develop branch will be closed in favor of this one. Please refer to the original PR for details on the discussion.
Contribution checklist