Skip to content

[Forwardport] Fix for #8222 #16429

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jul 2, 2018
Merged

[Forwardport] Fix for #8222 #16429

merged 1 commit into from
Jul 2, 2018

Conversation

0m3r
Copy link
Contributor

@0m3r 0m3r commented Jun 27, 2018

Description

Original PR: #16213

The shipping and estimate tax form doesn't display the form with country, city, postcode fields.
The form is in the dom, but hidden.

jquery.storageapi.min.js:2 Uncaught TypeError: Cannot read property 'htmlblock-shipping' of null

Fixed Issues

  1. Estimate Shipping and Tax Form not works due to js error in collapsible.js [proposed fix] #8222: Estimate Shipping and Tax Form not works due to js error in collapsible.js

Manual testing scenarios

  1. Open chrome dev console
  2. run: './././'.replace('.', '')
  3. run: './././'.replace(/./g,'')
  4. profit

Contribution checklist

  • Pull request has a meaningful description of its purpose
  • All commits are accompanied by meaningful commit messages
  • All new or changed code is covered with unit/integration tests (if applicable)
  • All automated tests passed successfully (all builds on Travis CI are green)

@magento-engcom-team
Copy link
Contributor

Hi @0m3r. Thank you for your contribution
Here is some useful tips how you can test your changes using Magento test environment.
Add the comment under your pull request to deploy test or vanilla Magento instance:

  • @magento-engcom-team give me test instance - deploy test instance based on PR changes
  • @magento-engcom-team give me {$VERSION} instance - deploy vanilla Magento instance

For more details, please, review the Magento Contributor Assistant documentation

@0m3r 0m3r changed the title Fix for #8222 Fix for #8222 (clone for 2.3-develop) Jun 27, 2018
@orlangur orlangur self-assigned this Jun 28, 2018
@orlangur orlangur changed the title Fix for #8222 (clone for 2.3-develop) [Forwardport] Fix for #8222 Jun 28, 2018
@magento-engcom-team
Copy link
Contributor

Hi @orlangur, thank you for the review.
ENGCOM-2147 has been created to process this Pull Request

@magento-engcom-team
Copy link
Contributor

Hi @0m3r. Thank you for your contribution.
We will aim to release these changes as part of 2.3.0.
Please check the release notes for final confirmation.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants