Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix for #8222 #16491

Merged
merged 2 commits into from
Jul 4, 2018
Merged

Fix for #8222 #16491

merged 2 commits into from
Jul 4, 2018

Conversation

gelanivishal
Copy link
Contributor

@gelanivishal gelanivishal commented Jul 3, 2018 •
edited by sidolov
Loading

Original Pull Request

#16213

Description

The shipping and estimate tax form doesn't display the form with country, city, postcode fields.
The form is in the dom, but hidden.

jquery.storageapi.min.js:2 Uncaught TypeError: Cannot read property 'htmlblock-shipping' of null

Fixed Issues

  1. Estimate Shipping and Tax Form not works due to js error in collapsible.js [proposed fix] #8222: Estimate Shipping and Tax Form not works due to js error in collapsible.js

Manual testing scenarios

  1. Open chrome dev console
  2. run: './././'.replace('.', '')
  3. run: './././'.replace(/./g,'')
  4. profit

Contribution checklist

  • Pull request has a meaningful description of its purpose
  • All commits are accompanied by meaningful commit messages
  • All new or changed code is covered with unit/integration tests (if applicable)
  • All automated tests passed successfully (all builds on Travis CI are green)

@magento-engcom-team magento-engcom-team added this to the Release: 2.1.15 milestone Jul 3, 2018
@orlangur orlangur self-assigned this Jul 3, 2018
@magento-engcom-team
Copy link
Contributor

Hi @orlangur, thank you for the review.
ENGCOM-2167 has been created to process this Pull Request

@magento-engcom-team
Copy link
Contributor

Hi @orlangur, thank you for the review.
ENGCOM-2167 has been created to process this Pull Request

@sidolov sidolov mentioned this pull request Jul 4, 2018
Closed
@magento-engcom-team magento-engcom-team merged commit f388069 into magento:2.1-develop Jul 4, 2018
magento-engcom-team pushed a commit that referenced this pull request Jul 4, 2018
ENGCOM-2167: Fix for #8222 #16491
f0a5e63
@magento-engcom-team
Copy link
Contributor

Hi @gelanivishal. Thank you for your contribution.
We will aim to release these changes as part of 2.1.15.
Please check the release notes for final confirmation.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@orlangur orlangur orlangur approved these changes

Assignees

@orlangur orlangur

@sidolov sidolov

Labels
Area: Lib/Frontend Progress: accept Release Line: 2.1
Projects
None yet
Milestone
Release: 2.1.15
Development

Successfully merging this pull request may close these issues.
5 participants
@gelanivishal @magento-engcom-team @orlangur @sidolov @0m3r