Skip to content

Conversation

MoT3rror
Copy link
Contributor

@MoT3rror MoT3rror commented Jul 5, 2018

Description

Fix issue where $block->getTotals() is not countable in Magento/Sales/view/adminhtml/templates/order/totalbar.php
getTotals() is set to protected in block not allowing template to access the method.

Manual testing scenarios

  1. Setup check payment method.
  2. Place order on frontend.
  3. Attempt to process invoice in backend.
  4. Unable to process invoice because of PHP error.

Contribution checklist

  • Pull request has a meaningful description of its purpose
  • All commits are accompanied by meaningful commit messages
  • All new or changed code is covered with unit/integration tests (if applicable)
  • All automated tests passed successfully (all builds on Travis CI are green)

…/view/adminhtml/templates/order/totalbar.php
@magento-cicd2
Copy link
Contributor

magento-cicd2 commented Jul 5, 2018

CLA assistant check
All committers have signed the CLA.

@magento-engcom-team
Copy link
Contributor

Hi @MoT3rror. Thank you for your contribution
Here is some useful tips how you can test your changes using Magento test environment.
Add the comment under your pull request to deploy test or vanilla Magento instance:

  • @magento-engcom-team give me test instance - deploy test instance based on PR changes
  • @magento-engcom-team give me {$VERSION} instance - deploy vanilla Magento instance

For more details, please, review the Magento Contributor Assistant documentation

@magento-engcom-team
Copy link
Contributor

@MoT3rror thank you for contributing. Please accept Community Contributors team invitation here to gain extended permissions for this repository.

@orlangur
Copy link
Contributor

orlangur commented Jul 9, 2018

@MoT3rror is this issue reproducible in 2.2-develop? Any contribution should be merged into it first.

@dverkade
Copy link
Member

dverkade commented Jul 9, 2018

I can reproduce this issue on Magento 2.3 Alpha and have created issue #16653 for this. However the changes introduced in this PR are not resolving the issue. It will display some totals in a weird place which should not be displayed there. Please see attached screenshot below.

image

@orlangur
Copy link
Contributor

orlangur commented Jul 9, 2018

Closing in favor of #16656

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants