Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Forwardport-2.3] Fix Translation of error message on cart for deleted bundle option. #16778

Conversation

swnsma
Copy link
Contributor

@swnsma swnsma commented Jul 13, 2018

Description

Manual testing scenarios

Pre-conditions

  1. Enabled Inline Translates.
  2. Bundle product #P1 - visible and saleable.
  3. Enabled multishipping.

Steps To Reproduce

  1. Go to Frontend.
  2. Add bundle product to cart.
  3. Go to cart page.
  4. Go to admin panel.
  5. Find bundle product #P1 in Products -> Catalog.
  6. Edit options (e.g. change order of items) and save the product.
  7. Flush cache (System -> Tools -> Cache Management -> Flush Magento Cache).
  8. Go to frontend.
  9. Refresh the page.

Expected Result:

  1. Error messages are shown.
  2. All messages are translatable.

Actual Result:

  1. Error messages are shown.
  2. The message 'The required options you selected are not available.' is not inline translatable.

Contribution checklist

  • Pull request has a meaningful description of its purpose
  • All commits are accompanied by meaningful commit messages
  • All new or changed code is covered with unit/integration tests (if applicable)
  • All automated tests passed successfully (all builds on Travis CI are green)

@magento-engcom-team magento-engcom-team added Partner: ISM eCompany Pull Request is created by partner ISM eCompany partners-contribution Pull Request is created by Magento Partner Component: Multishipping labels Jul 13, 2018
@magento-engcom-team
Copy link
Contributor

Hi @swnsma. Thank you for your contribution
Here is some useful tips how you can test your changes using Magento test environment.
Add the comment under your pull request to deploy test or vanilla Magento instance:

  • @magento-engcom-team give me test instance - deploy test instance based on PR changes
  • @magento-engcom-team give me {$VERSION} instance - deploy vanilla Magento instance

For more details, please, review the Magento Contributor Assistant documentation

@swnsma swnsma changed the title magento/magento2#?: Fix Translation of error message on cart for dele… [Forwardport-2.3] Fix Translation of error message on cart for deleted bundle option. Jul 13, 2018
@magento-engcom-team magento-engcom-team added this to the Release: 2.3.0 milestone Jul 13, 2018
…ted bundle option.

- change plugin sort order in case to prevent loading of not translatable messages for Localized exception in beforeDispatch plugin.
@magento-engcom-team
Copy link
Contributor

Hi @swnsma. Thank you for your contribution.
We will aim to release these changes as part of 2.3.0.
Please check the release notes for final confirmation.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Component: Multishipping Component: Store Partner: ISM eCompany Pull Request is created by partner ISM eCompany partners-contribution Pull Request is created by Magento Partner Progress: accept Release Line: 2.3
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants