Skip to content

Conversation

mhauri
Copy link

@mhauri mhauri commented Jul 16, 2018

Description

Direct type casting is up to 6x faster than using casting functions like strval(). So this pull request replaces the strval() functions by direct type casting to (string).

Similar PRs:

#16422 Replace intval() function by using direct type casting to (int) where no default value is needed
#16848 Replace floatval() function by using direct type casting to (float)

Contribution checklist

@magento-engcom-team
Copy link
Contributor

Hi @mhauri. Thank you for your contribution
Here is some useful tips how you can test your changes using Magento test environment.
Add the comment under your pull request to deploy test or vanilla Magento instance:

  • @magento-engcom-team give me test instance - deploy test instance based on PR changes
  • @magento-engcom-team give me {$VERSION} instance - deploy vanilla Magento instance

For more details, please, review the Magento Contributor Assistant documentation

@magento-engcom-team magento-engcom-team added this to the Release: 2.2.7 milestone Aug 3, 2018
@magento-engcom-team
Copy link
Contributor

Hi @orlangur, thank you for the review.
ENGCOM-2644 has been created to process this Pull Request

@magento-engcom-team
Copy link
Contributor

Hi @mhauri. Thank you for your contribution.
We will aim to release these changes as part of 2.2.7.
Please check the release notes for final confirmation.

Please, consider to port this solution to 2.3 release line.
You may use Porting tool to port commits automatically.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants