Skip to content

Conversation

jochhop
Copy link
Contributor

@jochhop jochhop commented Jul 25, 2018

Some conditions were divided in multiple ones when it was not really necessary in captcha extension

Description

Some captcha observers contained multiple conditions when it was not necessary

Fixed Issues (if relevant)

Code style improvement

Manual testing scenarios

N/A

Contribution checklist

  • Pull request has a meaningful description of its purpose
  • All commits are accompanied by meaningful commit messages
  • All new or changed code is covered with unit/integration tests (if applicable)
  • All automated tests passed successfully (all builds on Travis CI are green)

@magento-engcom-team magento-engcom-team added Partner: SNOW.DOG Pull Request is created by partner SNOW.DOG partners-contribution Pull Request is created by Magento Partner labels Jul 25, 2018
@magento-engcom-team
Copy link
Contributor

Hi @jochhop. Thank you for your contribution
Here is some useful tips how you can test your changes using Magento test environment.
Add the comment under your pull request to deploy test or vanilla Magento instance:

  • @magento-engcom-team give me test instance - deploy test instance based on PR changes
  • @magento-engcom-team give me {$VERSION} instance - deploy vanilla Magento instance

For more details, please, review the Magento Contributor Assistant documentation

@magento-engcom-team
Copy link
Contributor

Hi @jochhop. Thank you for your contribution.
We will aim to release these changes as part of 2.3.0.
Please check the release notes for final confirmation.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Component: Captcha Partner: SNOW.DOG Pull Request is created by partner SNOW.DOG partners-contribution Pull Request is created by Magento Partner Progress: accept Release Line: 2.3
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants