Skip to content

Use cast types instead of xyzval() #17511

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 9 commits into from
Sep 25, 2018

Conversation

sreichel
Copy link
Contributor

@sreichel sreichel commented Aug 10, 2018

Description

Replaced all

-boolval() with (bool)
-floatval() with (float)
-intval() with (int)
-strval() with (string)

Contribution checklist

  • Pull request has a meaningful description of its purpose
  • All commits are accompanied by meaningful commit messages
  • All new or changed code is covered with unit/integration tests (if applicable)
  • All automated tests passed successfully (all builds on Travis CI are green)

@magento-engcom-team
Copy link
Contributor

Hi @sreichel. Thank you for your contribution
Here is some useful tips how you can test your changes using Magento test environment.
Add the comment under your pull request to deploy test or vanilla Magento instance:

  • @magento-engcom-team give me test instance - deploy test instance based on PR changes
  • @magento-engcom-team give me {$VERSION} instance - deploy vanilla Magento instance

For more details, please, review the Magento Contributor Assistant documentation

@orlangur
Copy link
Contributor

Waiting for another PR with intval to be processed.

@ihor-sviziev ihor-sviziev removed their assignment Aug 11, 2018
@magento-engcom-team
Copy link
Contributor

Hi @sidolov, thank you for the review.
ENGCOM-3023 has been created to process this Pull Request

@sreichel
Copy link
Contributor Author

Close/reopen to trigger travis.

@sreichel sreichel closed this Sep 21, 2018
@sreichel sreichel reopened this Sep 21, 2018
@magento-engcom-team
Copy link
Contributor

Hi @sreichel. Thank you for your contribution.
We will aim to release these changes as part of 2.2.8.
Please check the release notes for final confirmation.

Please, consider to port this solution to 2.3 release line.
You may use Porting tool to port commits automatically.

@sreichel sreichel deleted the cleanup/cast-types branch October 30, 2018 15:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment