Fixed undefinded shipping method name issue #17492

[gelanivishal]

Description

Fixed undefined error on shipping method name is not set.

Fixed Issues (if relevant)

1. "- undefined" displayed in checkout summary when shipping method name is not set #17492: "- undefined" displayed in checkout summary when shipping method name is not set

Manual testing scenarios

1. Add new or edit any existing shipping methods with Method name field left as a blank field.
2. Add any product to the cart and go through the checkout to the last step.

Contribution checklist

• Pull request has a meaningful description of its purpose
• All commits are accompanied by meaningful commit messages
• All new or changed code is covered with unit/integration tests (if applicable)
• All automated tests passed successfully (all builds on Travis CI are green)

[magento-engcom-team]

Hi @gelanivishal. Thank you for your contribution
Here is some useful tips how you can test your changes using Magento test environment.
Add the comment under your pull request to deploy test or vanilla Magento instance:

• @magento-engcom-team give me test instance - deploy test instance based on PR changes
• @magento-engcom-team give me {$VERSION} instance - deploy vanilla Magento instance

For more details, please, review the Magento Contributor Assistant documentation

[magento-engcom-team]

Hi @VladimirZaets, thank you for the review.
ENGCOM-2743 has been created to process this Pull Request

[krzksz]

If I understand correctly, your code will return empty string if no method_title is found. Can we make it return carrier_title in that case? Then we would have e.g. Flat Rate instead of Flat Rate - undefined or empty string which is a best solution in my opinion.

[magento-engcom-team]

Hi @gelanivishal. Thank you for your contribution.
We will aim to release these changes as part of 2.2.7.
Please check the release notes for final confirmation.

Please, consider to port this solution to 2.3 release line.
You may use Porting tool to port commits automatically.