-
Notifications
You must be signed in to change notification settings - Fork 9.4k
[Forwardport] Review: Adding missing unit test for Observer #17704
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Forwardport] Review: Adding missing unit test for Observer #17704
Conversation
Hi @eduard13. Thank you for your contribution
For more details, please, review the Magento Contributor Assistant documentation |
/** | ||
* @var Review|PHPUnit_Framework_MockObject_MockObject | ||
*/ | ||
private $_resourceReviewMock; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please, remove underscores from the private properties. It's not a way to go if we want to be PSR-2 compatible ;)
https://www.php-fig.org/psr/psr-2/#42-properties
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@rogyar the naming was fixed.
I thought that it should be kept the naming as it is in the testable class.
Thank you.
Hi @rogyar, thank you for the review. |
Hi @eduard13. Thank you for your contribution. |
Original PR:
#17693
Description
This PR adds missing unit test for Review observer classes:
Fixed Issues (if relevant)
N/A
Manual testing scenarios
N/A
Contribution checklist