Skip to content

[Backport] Sales: Add unit test for validator model class #17940

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Sep 6, 2018
Merged

[Backport] Sales: Add unit test for validator model class #17940

merged 1 commit into from
Sep 6, 2018

Conversation

dmytro-ch
Copy link
Contributor

Original PR: #17876

Description

This PR adds missing unit test for:
\Magento\Sales\Model\Validator

Fixed Issues

N/A

Manual testing scenarios

N/A

Contribution checklist

  • Pull request has a meaningful description of its purpose
  • All commits are accompanied by meaningful commit messages
  • All new or changed code is covered with unit/integration tests (if applicable)
  • All automated tests passed successfully (all builds on Travis CI are green)

@dmytro-ch dmytro-ch requested a review from rogyar September 5, 2018 17:34
@magento-engcom-team magento-engcom-team added Partner: Atwix Pull Request is created by partner Atwix partners-contribution Pull Request is created by Magento Partner Component: Sales Release Line: 2.1 labels Sep 5, 2018
@magento-engcom-team magento-engcom-team added this to the Release: 2.1.16 milestone Sep 6, 2018
@magento-engcom-team magento-engcom-team merged commit 3fa49e5 into magento:2.1-develop Sep 6, 2018
magento-engcom-team pushed a commit that referenced this pull request Sep 6, 2018
ENGCOM-2928: [Backport] Sales: Add unit test for validator model class …
08cc7fe 
…#17940
@magento-engcom-team
Copy link
Contributor

Hi @dmytro-ch. Thank you for your contribution.
We will aim to release these changes as part of 2.1.16.
Please check the release notes for final confirmation.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rogyar rogyar Awaiting requested review from rogyar

Assignees

@rogyar rogyar

@sidolov sidolov

Labels
Component: Sales Partner: Atwix Pull Request is created by partner Atwix partners-contribution Pull Request is created by Magento Partner Progress: accept Release Line: 2.1
Projects
None yet
Milestone
Release: 2.1.16
Development

Successfully merging this pull request may close these issues.
4 participants
@dmytro-ch @magento-engcom-team @rogyar @sidolov