Skip to content

Conversation

magently
Copy link

@magently magently commented Sep 7, 2018

Description

Fixed currency Symbol setting back to default

Fixed Issues

  1. Currency symbol cannot be changed back to default value from admin panel in Single-store mode #17567: Currency symbol cannot be changed back to default value from admin panel in Single-store mode

Manual testing scenarios

  1. Set mode to Single-store in admin panel.
  2. Go to currency symbols section.
  3. Set custom currency symbol, then set it back to default.

Contribution checklist

  • Pull request has a meaningful description of its purpose
  • All commits are accompanied by meaningful commit messages
  • All new or changed code is covered with unit/integration tests (if applicable)
  • All automated tests passed successfully (all builds on Travis CI are green)

@magento-engcom-team
Copy link
Contributor

Hi @magently. Thank you for your contribution
Here is some useful tips how you can test your changes using Magento test environment.
Add the comment under your pull request to deploy test or vanilla Magento instance:

  • @magento-engcom-team give me test instance - deploy test instance based on PR changes
  • @magento-engcom-team give me {$VERSION} instance - deploy vanilla Magento instance

For more details, please, review the Magento Contributor Assistant documentation

@rogyar
Copy link
Contributor

rogyar commented Sep 8, 2018

@magento-engcom-team give me 2.2-develop instance

@magento-engcom-team
Copy link
Contributor

Hi @rogyar. Thank you for your request. I'm working on Magento 2.2-develop instance for you

@rogyar rogyar self-assigned this Sep 8, 2018
@magento-engcom-team
Copy link
Contributor

Hi @rogyar, here is your Magento instance.
Admin access: https://i-17966-2-2-develop.engcom.dev.magento.com/admin
Login: admin Password: 123123q
Instance will be terminated in up to 3 hours.

@rogyar
Copy link
Contributor

rogyar commented Sep 8, 2018

@magento-engcom-team give me test instance

@magento-engcom-team
Copy link
Contributor

Hi @rogyar. Thank you for your request. I'm working on Magento instance for you

@magento-engcom-team
Copy link
Contributor

Hi @rogyar, here is your new Magento instance.
Admin access: https://pr-17966.engcom.dev.magento.com/admin
Login: admin Password: 123123q

@magento-engcom-team
Copy link
Contributor

Hi @magently. Thank you for your contribution.
We will aim to release these changes as part of 2.2.8.
Please check the release notes for final confirmation.

Please, consider to port this solution to 2.3 release line.
You may use Porting tool to port commits automatically.

@magently magently deleted the fix/currency-symbol branch August 9, 2019 10:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants