Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix module uninstall shell command and composer removal w/out regression #18002

Merged
merged 2 commits into from Sep 22, 2018

Conversation

@Thundar
Copy link
Contributor

Thundar commented Sep 10, 2018

Description

There is a discrepancy between composer.lock and composer.json when removing a module via bin/magento module:uninstall command. Also, the output is wrong and the guide says it should do otherwise.
The removal option in the code solved the previous issue #5797 , but caused the new issue. The new change solves both.

Fixed Issues (if relevant)

  1. #17780: Module uninstall does not work with composer

Manual testing scenarios

  1. Install Magento with composer (2.2.x) and set it up
  2. Install Sample Datas with bin/magento sampledata:deploy
  3. Complete Sample Data installation: bin/magento setup:upgrade
  4. Remove one package: bin/magento module:uninstall Magento_CmsSampleData

Contribution checklist

  • Pull request has a meaningful description of its purpose
  • All commits are accompanied by meaningful commit messages
  • All new or changed code is covered with unit/integration tests (if applicable)
  • All automated tests passed successfully (all builds on Travis CI are green)
@magento-engcom-team

This comment has been minimized.

Copy link
Contributor

magento-engcom-team commented Sep 10, 2018

Hi @Thundar. Thank you for your contribution
Here is some useful tips how you can test your changes using Magento test environment.
Add the comment under your pull request to deploy test or vanilla Magento instance:

  • @magento-engcom-team give me test instance - deploy test instance based on PR changes
  • @magento-engcom-team give me {$VERSION} instance - deploy vanilla Magento instance

For more details, please, review the Magento Contributor Assistant documentation

@magento-engcom-team

This comment has been minimized.

Copy link
Contributor

magento-engcom-team commented Sep 10, 2018

@Thundar thank you for contributing. Please accept Community Contributors team invitation here to gain extended permissions for this repository.

@magento-engcom-team magento-engcom-team merged commit bf9b7a8 into magento:2.2-develop Sep 22, 2018
3 checks passed
3 checks passed
Codacy/PR Quality Review Up to standards. A positive pull request.
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
licence/cla Contributor License Agreement is signed.
Details
@magento-engcom-team

This comment has been minimized.

Copy link
Contributor

magento-engcom-team commented Sep 22, 2018

Hi @Thundar. Thank you for your contribution.
We will aim to release these changes as part of 2.2.8.
Please check the release notes for final confirmation.

Please, consider to port this solution to 2.3 release line.
You may use Porting tool to port commits automatically.

1 similar comment
@magento-engcom-team

This comment has been minimized.

Copy link
Contributor

magento-engcom-team commented Sep 22, 2018

Hi @Thundar. Thank you for your contribution.
We will aim to release these changes as part of 2.2.8.
Please check the release notes for final confirmation.

Please, consider to port this solution to 2.3 release line.
You may use Porting tool to port commits automatically.

@magento-engcom-team magento-engcom-team added this to Ready to Port in Ports Wanted Sep 22, 2018
@magento-engcom-team magento-engcom-team moved this from Ready to Port to Port to 2.3 Created in Ports Wanted Sep 23, 2018
@Thundar Thundar deleted the Thundar:2.2issue/17780 branch Sep 24, 2018
@magento-engcom-team magento-engcom-team moved this from Port to 2.3 Created to Port to 2.3 Merged in Ports Wanted Sep 26, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Ports Wanted
  
Port to 2.3 Merged
3 participants
You can’t perform that action at this time.