Add CatalogSearch no results handle

[progreg]

Description

Added default handle if result count of search results is zero. The feature was implemented for both search variations. For a simple search, the handle will be catalogsearch_result_index_noresults and for advanced search, it will be catalogsearch_advanced_result_noresults.

Fixed Issues (if relevant)

1. Add a custom layout handle when there are no search results #18038: Add a custom layout handle when there are no search results

Contribution checklist

• Pull request has a meaningful description of its purpose
• All commits are accompanied by meaningful commit messages
• All new or changed code is covered with unit/integration tests (if applicable)
• All automated tests passed successfully (all builds on Travis CI are green)

[magento-cicd2]

All committers have signed the CLA.

[magento-engcom-team]

Hi @progreg. Thank you for your contribution
Here is some useful tips how you can test your changes using Magento test environment.
Add the comment under your pull request to deploy test or vanilla Magento instance:

• @magento-engcom-team give me test instance - deploy test instance based on PR changes
• @magento-engcom-team give me $VERSION instance - deploy vanilla Magento instance

For more details, please, review the Magento Contributor Assistant documentation

[okorshenko]

@magento-engcom-team give me test instance

[magento-engcom-team]

Hi @okorshenko. Thank you for your request. I'm working on Magento instance for you

[magento-engcom-team]

Hi @okorshenko, here is your new Magento instance.
Admin access: https://pr-18069.engcom.dev.magento.com/admin
Login: admin Password: 123123q

[jakwinkler]

I'm happy that PR was created to this but... it does not work as expected.
I've implemented this pull request to 2.2.5 version (EE), created a file catalogsearch_result_noresults.xml in Magento CatalogSearch module with following content

<?xml version="1.0"?>
<page xmlns:xsi="http://www.w3.org/2001/XMLSchema-instance" layout="1column"
   xsi:noNamespaceSchemaLocation="urn:magento:framework:View/Layout/etc/page_configuration.xsd">
    <referenceContainer name="header" remove="true" />
    <referenceContainer name="header-wrapper" remove="true" />
    <referenceContainer name="footer" remove="true" />
</page>

Am I doing something wrong? Basically the layout xml file is not processed at all... at least thats what I can tell.

For now I will simply create a redirect to a new controller where layout handles work fine.

[ishakhsuvarov]

Hi @progreg
Could you please take a look at the comments above?

Thanks!

[progreg]

@qsolutions-pl, thanks for response. I will check it.

[progreg]

Hi @qsolutions-pl, the issue was fixed and now you can check again it by using next handles:

• catalogsearch_result_index_noresults
• catalogsearch_advanced_result_noresults

[jakwinkler]

@progreg I do see layout handles being used when I implemented this pull request to my magento installation. Even tests pass when I run them.
But... frontend page still uses 2 columns instead of 1 - that is what I'm trying to accomplish - cache cleared, di cleared :(
To solve this I've created a plugin on Result block and redirect user to a new controller action for now.

[ishakhsuvarov]

Hi @qsolutions-pl
Looks like you already have a solution that is working for you. Feel free to submit it with another Pull Request or even push additional commits to this one.

[progreg]

@qsolutions-pl, yeap, you are right. I will take a look again maybe i missed something. Thanks for response

[progreg]

@qsolutions-pl, problem with layout was fixed. Please take a look if you still interested in such improvement. Thanks

[sivaschenko]

@progreg thanks for the contribution! Can you please add phpdocs to all added constants and methods.

[sivaschenko]

please add docblocks/comments for all introduced constants and methods

[progreg]

done

[magento-engcom-team]

Hi @sivaschenko, thank you for the review.
ENGCOM-3526 has been created to process this Pull Request

[magento-engcom-team]

Hi @progreg. Thank you for your contribution.
We will aim to release these changes as part of 2.3.1.
Please check the release notes for final confirmation.