Skip to content

Update db schema comments #18122

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Sep 26, 2018
Merged

Update db schema comments #18122

merged 2 commits into from
Sep 26, 2018

Conversation

hryvinskyi
Copy link
Member

Description

Update DB Schema Comments

Contribution checklist

  • Pull request has a meaningful description of its purpose
  • All commits are accompanied by meaningful commit messages
  • All new or changed code is covered with unit/integration tests (if applicable)
  • All automated tests passed successfully (all builds on Travis CI are green)

@magento-engcom-team
Copy link
Contributor

Hi @hryvinskyi. Thank you for your contribution
Here is some useful tips how you can test your changes using Magento test environment.
Add the comment under your pull request to deploy test or vanilla Magento instance:

  • @magento-engcom-team give me test instance - deploy test instance based on PR changes
  • @magento-engcom-team give me $VERSION instance - deploy vanilla Magento instance

For more details, please, review the Magento Contributor Assistant documentation

rogyar
rogyar reviewed Sep 22, 2018
View reviewed changes
app/code/Magento/CatalogRule/etc/db_schema.xml Outdated
@@ -156,7 +157,8 @@
</table>
<table name="catalogrule_customer_group" resource="default" engine="innodb"
comment="Catalog Rules To Customer Groups Relations">
<column xsi:type="int" name="rule_id" padding="10" unsigned="true" nullable="false" identity="false"/>
<column xsi:type="int" name="rule_id" padding="10" unsigned="true" nullable="false" identity="false"
comment="Rule Id"/>
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should it be Rule ID as well? :)

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

yes, it's a typo :)

@rogyar rogyar self-assigned this Sep 22, 2018
@magento-engcom-team magento-engcom-team added this to the Release: 2.3.1 milestone Sep 24, 2018
@magento-engcom-team magento-engcom-team merged commit e20dfc3 into magento:2.3-develop Sep 26, 2018
magento-engcom-team pushed a commit that referenced this pull request Sep 26, 2018
ENGCOM-3033: Update db schema comments #18122
e2da973
@magento-engcom-team
Copy link
Contributor

Hi @hryvinskyi. Thank you for your contribution.
We will aim to release these changes as part of 2.3.1.
Please check the release notes for final confirmation.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rogyar rogyar rogyar left review comments

Assignees

@rogyar rogyar

Labels
Cleanup Component: multiple Progress: accept Release Line: 2.3
Projects
None yet
Milestone
Release: 2.3.1
Development

Successfully merging this pull request may close these issues.
3 participants
@hryvinskyi @magento-engcom-team @rogyar