Skip to content

[Forwardport] Update time12h javascript validation rule to be compatible with js minify #18141

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Sep 26, 2018

Conversation

mage2pratik
Copy link
Contributor

@mage2pratik mage2pratik commented Sep 19, 2018

Description

The space in the validation rule causes this rule to not work correctly when js minify is enabled, as it strips the space out of the validation rule regex.

Fixed Issues (if relevant)

  1. Update time12h javascript validation rule to be compatible with js minify #17652: Update time12h javascript validation rule to be compatible with js minify

Manual testing scenarios

  1. Validation rule with space doesn't work if js minify is enabled

Contribution checklist

  • Pull request has a meaningful description of its purpose
  • All commits are accompanied by meaningful commit messages
  • All new or changed code is covered with unit/integration tests (if applicable)
  • All automated tests passed successfully (all builds on Travis CI are green)

Original PR

#17652

@magento-engcom-team
Copy link
Contributor

Hi @mage2pratik. Thank you for your contribution
Here is some useful tips how you can test your changes using Magento test environment.
Add the comment under your pull request to deploy test or vanilla Magento instance:

  • @magento-engcom-team give me test instance - deploy test instance based on PR changes
  • @magento-engcom-team give me $VERSION instance - deploy vanilla Magento instance

For more details, please, review the Magento Contributor Assistant documentation

@VladimirZaets VladimirZaets self-assigned this Sep 20, 2018
@VladimirZaets VladimirZaets self-requested a review September 20, 2018 07:48
@magento-engcom-team
Copy link
Contributor

Hi @VladimirZaets, thank you for the review.
ENGCOM-3018 has been created to process this Pull Request

@sidolov sidolov changed the title Update time12h javascript validation rule to be compatible with js minify [Forwardport] Update time12h javascript validation rule to be compatible with js minify Sep 21, 2018
@magento-engcom-team magento-engcom-team merged commit cfa4d60 into magento:2.3-develop Sep 26, 2018
magento-engcom-team pushed a commit that referenced this pull request Sep 26, 2018
@magento-engcom-team
Copy link
Contributor

Hi @mage2pratik. Thank you for your contribution.
We will aim to release these changes as part of 2.3.1.
Please check the release notes for final confirmation.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants