Skip to content

Conversation

mage2pratik
Copy link
Contributor

Description

Direct type casting is up to 6x faster than using casting functions like intval(). So this pull request replaces the intval() functions by direct type casting to (int) where no default value is needed.

Fixed Issues (if relevant)

  1. [2.3] Changed intval($val) to (int) $val, since it is faster: #18035: [2.3] Changed intval($val) to (int) $val, since it is faster:

Manual testing scenarios

N/A

Contribution checklist

  • Pull request has a meaningful description of its purpose
  • All commits are accompanied by meaningful commit messages
  • All new or changed code is covered with unit/integration tests (if applicable)
  • All automated tests passed successfully (all builds on Travis CI are green)

@magento-engcom-team magento-engcom-team added Partner: Krish TechnoLabs partners-contribution Pull Request is created by Magento Partner Component: Framework/Webapi USE ONLY for FRAMEWORK RELATED BUG! E.g If bug related to Catalog WEB API use just Catalog Component: Framework/View Component: Framework/System Component: Framework/Image Component: Framework/Data Component: Framework/Exception Component: Framework/Mail Component: Framework/DB USE ONLY for FRAMEWORK RELATED BUG! Component: Framework/Setup USE ONLY for FRAMEWORK RELATED BUG! E.g If bug occurs during Catalog Setup use just Catalog Component: Framework/HTTP Release Line: 2.3 labels Sep 19, 2018
@magento-engcom-team
Copy link
Contributor

Hi @mage2pratik. Thank you for your contribution
Here is some useful tips how you can test your changes using Magento test environment.
Add the comment under your pull request to deploy test or vanilla Magento instance:

  • @magento-engcom-team give me test instance - deploy test instance based on PR changes
  • @magento-engcom-team give me $VERSION instance - deploy vanilla Magento instance

For more details, please, review the Magento Contributor Assistant documentation

@VladimirZaets VladimirZaets self-assigned this Sep 20, 2018
@magento-engcom-team magento-engcom-team added this to the Release: 2.3.1 milestone Sep 20, 2018
@magento-engcom-team magento-engcom-team merged commit bbf1c0c into magento:2.3-develop Sep 25, 2018
magento-engcom-team pushed a commit that referenced this pull request Sep 25, 2018
@magento-engcom-team
Copy link
Contributor

Hi @mage2pratik. Thank you for your contribution.
We will aim to release these changes as part of 2.3.1.
Please check the release notes for final confirmation.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Component: Framework/Data Component: Framework/DB USE ONLY for FRAMEWORK RELATED BUG! Component: Framework/Exception Component: Framework/HTTP Component: Framework/Image Component: Framework/Mail Component: Framework/Setup USE ONLY for FRAMEWORK RELATED BUG! E.g If bug occurs during Catalog Setup use just Catalog Component: Framework/System Component: Framework/View Component: Framework/Webapi USE ONLY for FRAMEWORK RELATED BUG! E.g If bug related to Catalog WEB API use just Catalog Partner: Krish TechnoLabs partners-contribution Pull Request is created by Magento Partner Progress: accept Release Line: 2.3
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants