Skip to content

[Forwardport] [remove] rich snippet declaration on grouped product #18198

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Sep 26, 2018
Merged

[Forwardport] [remove] rich snippet declaration on grouped product #18198

merged 1 commit into from
Sep 26, 2018

Conversation

AurelienLavorel
Copy link
Member

@AurelienLavorel AurelienLavorel commented Sep 22, 2018

Original Pull Request

#17919

Rich snippet grouped product

Description

Structured data validation on grouped products are failing.

Manual testing scenarios

  1. Use Google validator tool: https://search.google.com/structured-data/testing-tool?hl=en#url=http%3A%2F%2Fmagento2-demo.nexcess.net%2Fset-of-sprite-yoga-straps.html
  2. Check that no errors are fired

Contribution checklist

  • Pull request has a meaningful description of its purpose
  • All commits are accompanied by meaningful commit messages
  • All new or changed code is covered with unit/integration tests (if applicable)
  • All automated tests passed successfully (all builds on Travis CI are green)

@magento-engcom-team
Copy link
Contributor

Hi @AurelienLavorel. Thank you for your contribution
Here is some useful tips how you can test your changes using Magento test environment.
Add the comment under your pull request to deploy test or vanilla Magento instance:

  • @magento-engcom-team give me test instance - deploy test instance based on PR changes
  • @magento-engcom-team give me $VERSION instance - deploy vanilla Magento instance

For more details, please, review the Magento Contributor Assistant documentation

@magento-engcom-team
Copy link
Contributor

Hi @aleron75, thank you for the review.
ENGCOM-3030 has been created to process this Pull Request

@magento-engcom-team
Copy link
Contributor

Hi @AurelienLavorel. Thank you for your contribution.
We will aim to release these changes as part of 2.3.1.
Please check the release notes for final confirmation.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants