Skip to content

Resolve typo despatch event #18372

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
Oct 31, 2018
Merged

Resolve typo despatch event #18372

Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
5937495
resolve typo in dispatchevent
neeta-wagento Oct 4, 2018
e878105
add deprectaed in event arguments
neeta-wagento Oct 19, 2018
6178035
add old event
neeta-wagento Oct 29, 2018
2647a89
add proper @deprecated and @see
neeta-wagento Oct 29, 2018
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 9 additions & 0 deletions app/code/Magento/CatalogSearch/Model/Indexer/Fulltext/Action/DataProvider.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -316,11 +316,20 @@ public function getSearchableAttributes($backendType = null)
/** @var \Magento\Eav\Model\Entity\Attribute[] $attributes */
$attributes = $productAttributes->getItems();

/**
* @deprecated Event argument catelogsearch_searchable_attributes_load_after.
* @see catalogsearch_searchable_attributes_load_after instead.
*/
$this->eventManager->dispatch(
'catelogsearch_searchable_attributes_load_after',
['engine' => $this->engine, 'attributes' => $attributes]
);

$this->eventManager->dispatch(
'catalogsearch_searchable_attributes_load_after',
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

As event cannot be removed, add a comment near old one that it is deprecated and add one more event dispatching, with corrected name.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@orlangur Thankyou for review. I have added add a comment near old one that it is deprecated and add one more event dispatching, with corrected name.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

After the change, old event must still be dispatched.

Also, do not specify version near deprecation tag, it is done automatically when needed.

['engine' => $this->engine, 'attributes' => $attributes]
);

$entity = $this->eavConfig->getEntityType(\Magento\Catalog\Model\Product::ENTITY)->getEntity();

foreach ($attributes as $attribute) {
Expand Down