Skip to content

Use SVG badge #18439

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Oct 12, 2018
Merged

Use SVG badge #18439

merged 1 commit into from
Oct 12, 2018

Conversation

hugovk
Copy link
Contributor

@hugovk hugovk commented Oct 7, 2018

Description

Use SVG Crowdin badge instead of PNG, for visual consistency with others.

Also add some missing fullstops, and because there's just one option under "Install Magento", there's no need to say "see either".

Manual testing scenarios

  1. Visit the README in the PR
  2. Check the badge and text is improved

Contribution checklist

  • Pull request has a meaningful description of its purpose
  • All commits are accompanied by meaningful commit messages
  • [n/a] All new or changed code is covered with unit/integration tests (if applicable)
  • [n/a] All automated tests passed successfully (all builds on Travis CI are green)

Before

image

After

image

@hugovk
Use SVG badge
a4ac677 
And fix some text

[CI skip]
@magento-cicd2
Copy link
Contributor

magento-cicd2 commented Oct 7, 2018 •
edited
Loading

CLA assistant check
All committers have signed the CLA.

@magento-engcom-team magento-engcom-team added this to the Release: 2.3.1 milestone Oct 8, 2018
@hugovk hugovk mentioned this pull request Oct 9, 2018
Closed
3 tasks
@magento-engcom-team magento-engcom-team merged commit a4ac677 into magento:2.3-develop Oct 12, 2018
magento-engcom-team pushed a commit that referenced this pull request Oct 12, 2018
ENGCOM-3125: Use SVG badge #18439
baee6f0
@magento-engcom-team
Copy link
Contributor

Hi @hugovk. Thank you for your contribution.
We will aim to release these changes as part of 2.3.1.
Please check the release notes for final confirmation.

@hugovk hugovk deleted the patch-1 branch October 12, 2018 11:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@sidolov sidolov

Labels
Cleanup Progress: accept Release Line: 2.3
Projects
None yet
Milestone
Release: 2.3.1
Development

Successfully merging this pull request may close these issues.
4 participants
@hugovk @magento-cicd2 @magento-engcom-team @sidolov