Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

magento-engcom/import-export-improvements#51: fix for uploader filepath #18810

Conversation

sagaltsev
Copy link

Description (*)

Move call to _setUploadFile to after the initation of $this-> _directory

Fixed Issues (if relevant)

  1. Unable to instantiate the catalog import uploader with $filePath set magento-engcom/import-export-improvements#51

Manual testing scenarios (*)

  1. Using the factory pattern you instantiate the class Magento\CatalogImportExport\Model\Import\Uploader with $filePath defined

Contribution checklist (*)

  • Pull request has a meaningful description of its purpose
  • All commits are accompanied by meaningful commit messages
  • All new or changed code is covered with unit/integration tests (if applicable)
  • All automated tests passed successfully (all builds on Travis CI are green)

@magento-cicd2
Copy link
Contributor

magento-cicd2 commented Oct 25, 2018

CLA assistant check
All committers have signed the CLA.

@magento-engcom-team
Copy link
Contributor

Hi @sawebvisum. Thank you for your contribution
Here is some useful tips how you can test your changes using Magento test environment.
Add the comment under your pull request to deploy test or vanilla Magento instance:

  • @magento-engcom-team give me test instance - deploy test instance based on PR changes
  • @magento-engcom-team give me $VERSION instance - deploy vanilla Magento instance

For more details, please, review the Magento Contributor Assistant documentation

@VladimirZaets VladimirZaets self-assigned this Oct 25, 2018
@VladimirZaets
Copy link
Contributor

Hi @sawebvisum, please, sign CLA, otherwise, we can't process your pull request

@sagaltsev
Copy link
Author

@VladimirZaets already assigned.

@magento-engcom-team
Copy link
Contributor

Hi @VladimirZaets, thank you for the review.
ENGCOM-3274 has been created to process this Pull Request

@magento-engcom-team
Copy link
Contributor

@sawebvisum thank you for contributing. Please accept Community Contributors team invitation here to gain extended permissions for this repository.

@magento-engcom-team magento-engcom-team merged commit 35356ef into magento:2.3-develop Nov 6, 2018
@magento-engcom-team
Copy link
Contributor

Hi @sawebvisum. Thank you for your contribution.
We will aim to release these changes as part of 2.3.1.
Please check the release notes for final confirmation.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants