Skip to content

Conversation

ghost
Copy link

@ghost ghost commented Oct 28, 2018

Description (*)

I think we should handle 302 redirection. We should check the next header if there is 302 redirection with url.

Fixed Issues (if relevant)

  1. can't import external http to https redirecting images by default csv import #18839: can't import external http to https redirecting images by default csv import

Manual testing scenarios (*)

  1. Use any image url with redirection like http://midwest-wholesale-staging.cloud.akeneo.com/bundles/pimui/images/info-user.png
  2. It will redirect to https://midwest-wholesale-staging.cloud.akeneo.com/bundles/pimui/images/info-user.png and it is valid image.

Contribution checklist (*)

  • Pull request has a meaningful description of its purpose
  • All commits are accompanied by meaningful commit messages
  • All new or changed code is covered with unit/integration tests (if applicable)
  • All automated tests passed successfully (all builds on Travis CI are green)

@magento-engcom-team
Copy link
Contributor

Hi @rahulwebkul. Thank you for your contribution
Here is some useful tips how you can test your changes using Magento test environment.
Add the comment under your pull request to deploy test or vanilla Magento instance:

  • @magento-engcom-team give me test instance - deploy test instance based on PR changes
  • @magento-engcom-team give me $VERSION instance - deploy vanilla Magento instance

For more details, please, review the Magento Contributor Assistant documentation

@ghost ghost changed the title fixed - can't import external http to https redirecting images by def… fixed - can't import external http to https redirecting images by default csv import Oct 28, 2018
@ghost ghost added Reproduced on 2.2.x The issue has been reproduced on latest 2.2 release Reproduced on 2.3.x The issue has been reproduced on latest 2.3 release and removed Reproduced on 2.2.x The issue has been reproduced on latest 2.2 release labels Oct 28, 2018
@aleron75 aleron75 self-assigned this Nov 2, 2018
@magento-engcom-team magento-engcom-team added this to the Release: 2.3.1 milestone Nov 2, 2018
@aleron75
Copy link
Contributor

aleron75 commented Nov 2, 2018

Hello @rahulwebkul thanks for your submission.

Unless you have already done it, don't forget that, once merged, you can easily port this PR to other branches with the Porting Tool, read more here.

@magento-engcom-team
Copy link
Contributor

Hi @aleron75, thank you for the review.
ENGCOM-3368 has been created to process this Pull Request

@magento-engcom-team
Copy link
Contributor

Hi @rahulwebkul. Thank you for your contribution.
We will aim to release these changes as part of 2.3.1.
Please check the release notes for final confirmation.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants