Skip to content

Conversation

nirav-kadiya
Copy link
Contributor

Original Pull Request

#18857

Description (*)

Fixed issue of default tax region/state appears in customer & order data

Fixed Issues (if relevant)

  1. Default tax region/state appears in customer & order data #16684: Default tax region/state appears in customer & order data

Manual testing scenarios (*)

  1. Set a default tax region in Stores > Configuration > Sales > Tax
  2. Complete an order

Contribution checklist (*)

  • Pull request has a meaningful description of its purpose
  • All commits are accompanied by meaningful commit messages
  • All new or changed code is covered with unit/integration tests (if applicable)
  • All automated tests passed successfully (all builds on Travis CI are green)

@magento-engcom-team magento-engcom-team added Partner: Krish TechnoLabs partners-contribution Pull Request is created by Magento Partner labels Nov 24, 2018
@magento-engcom-team
Copy link
Contributor

Hi @ssp58bleuciel. Thank you for your contribution
Here is some useful tips how you can test your changes using Magento test environment.
Add the comment under your pull request to deploy test or vanilla Magento instance:

  • @magento-engcom-team give me test instance - deploy test instance based on PR changes
  • @magento-engcom-team give me 2.3-develop instance - deploy vanilla Magento instance

For more details, please, review the Magento Contributor Assistant documentation

@magento-engcom-team magento-engcom-team added this to the Release: 2.3.1 milestone Nov 26, 2018
@magento-engcom-team
Copy link
Contributor

@ssp58bleuciel thank you for contributing. Please accept Community Contributors team invitation here to gain extended permissions for this repository.

@sivaschenko
Copy link
Member

@magento-engcom-team give me test instance

@magento-engcom-team
Copy link
Contributor

Hi @sivaschenko. Thank you for your request. I'm working on Magento instance for you

@magento-engcom-team
Copy link
Contributor

Hi @sivaschenko, here is your new Magento instance.
Admin access: https://pr-19387.instances.magento-community.engineering/admin
Login: admin Password: 123123q

@sivaschenko
Copy link
Member

@magento-engcom-team give me 2.3-develop instance

@magento-engcom-team
Copy link
Contributor

Hi @sivaschenko. Thank you for your request. I'm working on Magento 2.3-develop instance for you

@magento-engcom-team
Copy link
Contributor

Hi @sivaschenko, here is your Magento instance.
Admin access: https://i-19387-2-3-develop.instances.magento-community.engineering/admin
Login: admin Password: 123123q
Instance will be terminated in up to 3 hours.

@sivaschenko
Copy link
Member

This fix is changing the default applied tax on checkout when a region is not selected. Now instead of tax for default region - tax for a country ('*' region) will be applied.

@magento-engcom-team
Copy link
Contributor

Hi @ssp58bleuciel. Thank you for your contribution.
We will aim to release these changes as part of 2.3.1.
Please check the release notes for final confirmation.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants