Skip to content

Fix issue 19501 - Sales order Bundle product item alignment issue #19502

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 4 commits into from
Jan 29, 2019
Merged

Fix issue 19501 - Sales order Bundle product item alignment issue #19502

merged 4 commits into from
Jan 29, 2019

Conversation

abrarpathan19
Copy link
Contributor

@abrarpathan19 abrarpathan19 commented Dec 1, 2018 •
edited
Loading

Description (*)

  1. Magento 2.3 Develop
    Sales order Bundle product item alignment issue

Fixed Issues (if relevant)

  1. Sales order Bundle product item alignment issue #19501: Sales order Bundle product item alignment issue

Manual testing scenarios (*)

  1. Admin -> Sales -> Order -> Create New Order
  2. Select Customer -> Add Product
  3. Choose Bundle Product -> Configure

Contribution checklist (*)

  • Pull request has a meaningful description of its purpose
  • All commits are accompanied by meaningful commit messages
  • All new or changed code is covered with unit/integration tests (if applicable)
  • All automated tests passed successfully (all builds on Travis CI are green)

@magento-engcom-team
Copy link
Contributor

Hi @abrarpathan19. Thank you for your contribution
Here is some useful tips how you can test your changes using Magento test environment.
Add the comment under your pull request to deploy test or vanilla Magento instance:

  • @magento-engcom-team give me test instance - deploy test instance based on PR changes
  • @magento-engcom-team give me 2.3-develop instance - deploy vanilla Magento instance

For more details, please, review the Magento Contributor Assistant documentation

sivaschenko
sivaschenko requested changes Dec 2, 2018
View reviewed changes
Copy link
Member

@sivaschenko sivaschenko left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@abrarpathan19 thanks for the contribution, please see the review notes

app/design/adminhtml/Magento/backend/web/css/source/forms/_fields.less Outdated
@@ -148,6 +149,11 @@
}
}
}
&.composite-bundle{
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please move styles related to bundle product to app/design/aminhtml/Magento_Bundle/web/css/source/_module.less. Also, please add spaces before opening brackets.

app/design/adminhtml/Magento/backend/web/css/source/forms/_fields.less Outdated
@@ -121,6 +121,7 @@

> .admin__field-control {
#mix-grid .column(@field-control-grid__column, @field-grid__columns);
padding-top: 7px;
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If the change is actual only for bundle product form, it would be better to use more strict selector

@sivaschenko sivaschenko self-assigned this Dec 2, 2018
@magento-engcom-team magento-engcom-team added this to the Release: 2.3.1 milestone Dec 5, 2018
@magento-engcom-team
Copy link
Contributor

Hi @sivaschenko, thank you for the review.
ENGCOM-3621 has been created to process this Pull Request

@sivaschenko
Copy link
Member

Hi @abrarpathan19 please take a look at the screenshot:
image
After applying the fix all the bundle items options are shifted to the top.

@abrarpathan19
Copy link
Contributor Author

@sivaschenko
I have updated code, please review.

@sivaschenko
Copy link
Member

@magento-engcom-team give me test instance

@magento-engcom-team
Copy link
Contributor

Hi @sivaschenko. Thank you for your request. I'm working on Magento instance for you

@magento-engcom-team
Copy link
Contributor

Hi @sivaschenko, here is your new Magento instance.
Admin access: https://pr-19502.instances.magento-community.engineering/admin
Login: admin Password: 123123q

@okorshenko okorshenko removed this from the Release: 2.3.1 milestone Jan 28, 2019
@magento-engcom-team magento-engcom-team mentioned this pull request Jan 29, 2019
Closed
@magento-engcom-team magento-engcom-team merged commit 2479f44 into magento:2.3-develop Jan 29, 2019
@ghost
Copy link

ghost commented Jan 29, 2019

Hi @abrarpathan19, thank you for your contribution!
Please, complete Contribution Survey, it will take less than a minute.
Your feedback will help us to improve contribution process.

@magento-engcom-team
Copy link
Contributor

Hi @abrarpathan19. Thank you for your contribution.
We will aim to release these changes as part of 2.3.1.
Please check the release notes for final confirmation.

@magento-engcom-team magento-engcom-team added this to the Release: 2.3.1 milestone Jan 29, 2019
magento-engcom-team pushed a commit that referenced this pull request Jan 29, 2019
@sivaschenko
ENGCOM-3621: Fix issue 19501 - Sales order Bundle product item alignm…
d40c65c 
…ent issue #19502
@abrarpathan19 abrarpathan19 mentioned this pull request Jan 29, 2019
Merged
4 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sivaschenko sivaschenko sivaschenko approved these changes

Assignees

@sivaschenko sivaschenko

Labels
Area: Design/Frontend Award: bug fix Partner: Krish TechnoLabs partners-contribution Pull Request is created by Magento Partner Progress: accept Release Line: 2.3
Projects
None yet
Milestone
Release: 2.3.1
Development

Successfully merging this pull request may close these issues.
4 participants
@abrarpathan19 @magento-engcom-team @sivaschenko @okorshenko