Skip to content

Issue fixed #19985 Send email confirmation popup close button area ov… #19986

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Jan 23, 2019
Merged

Issue fixed #19985 Send email confirmation popup close button area ov… #19986

merged 2 commits into from
Jan 23, 2019

Conversation

cedarvinda
Copy link
Member

Issue fixed #19985 Send email confirmation popup close button area overlapping

Description (*)

Send email confirmation popup close button area overlapping

Fixed Issues (if relevant)

#19985

Manual testing scenarios (*)

Step 1: Login to admin panel
Step 2: Go to sales > order grid
Step 3: Edit any order
Step 4: Please click on send email from above links (Now you ref from actual result screenshot)

Contribution checklist (*)

  • Pull request has a meaningful description of its purpose
  • All commits are accompanied by meaningful commit messages
  • All new or changed code is covered with unit/integration tests (if applicable)
  • All automated tests passed successfully (all builds on Travis CI are green)

@cedarvinda
Issue fixed #19985 Send email confirmation popup close button area ov…
d9620c6 
…erlapping to content

Issue fixed #19985 Send email confirmation popup close button area overlapping to content
@magento-engcom-team
Copy link
Contributor

Hi @cedarvinda. Thank you for your contribution
Here is some useful tips how you can test your changes using Magento test environment.
Add the comment under your pull request to deploy test or vanilla Magento instance:

  • @magento-engcom-team give me test instance - deploy test instance based on PR changes
  • @magento-engcom-team give me 2.3-develop instance - deploy vanilla Magento instance

For more details, please, review the Magento Contributor Assistant documentation

VladimirZaets
VladimirZaets reviewed Dec 27, 2018
View reviewed changes
app/design/adminhtml/Magento/backend/web/css/source/components/_modals_extend.less Outdated

&:active,
&:focus {
background: transparent;
padding-right: @modal-popup__padding + (@modal-action-close__font-size - @modal-action-close__active__font-size) / 2;
padding-top: @modal-popup__padding + (@modal-action-close__font-size - @modal-action-close__active__font-size) / 2;
padding-right: 1rem;
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @cedarvinda. Thanks for collaboration. Please use less variables to declare padding size.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @VladimirZaets Thank for updating for this .. I will use less variable.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hello @VladimirZaets Now added less variables to declare padding size.

@VladimirZaets VladimirZaets self-assigned this Dec 27, 2018
@cedarvinda
Issue fixed #19985 Send email confirmation popup close button area ov…
8f4942a 
…erlapping

Issue fixed #19985 Send email confirmation popup close button area overlapping
@cedarvinda
Copy link
Member Author

@VladimirZaets please review this now.

@cedarvinda cedarvinda requested review from nuzil and removed request for VladimirZaets January 8, 2019 07:03
@cedarvinda cedarvinda assigned nuzil and unassigned VladimirZaets Jan 8, 2019
@cedarvinda
Copy link
Member Author

@nuzil can you please review this solution please ?

@nuzil
Copy link
Contributor

nuzil commented Jan 8, 2019

@magento-engcom-team give me test instance

@magento-engcom-team
Copy link
Contributor

Hi @nuzil. Thank you for your request. I'm working on Magento instance for you

@nuzil
Copy link
Contributor

nuzil commented Jan 10, 2019

@magento-engcom-team give me test instance

@magento-engcom-team
Copy link
Contributor

Hi @nuzil. Thank you for your request. I'm working on Magento instance for you

@magento-engcom-team
Copy link
Contributor

Hi @nuzil, here is your new Magento instance.
Admin access: https://pr-19986.instances.magento-community.engineering/admin
Login: admin Password: 123123q

@magento-engcom-team magento-engcom-team added this to the Release: 2.3.1 milestone Jan 14, 2019
@magento-engcom-team
Copy link
Contributor

Hi @nuzil, thank you for the review.
ENGCOM-3847 has been created to process this Pull Request

@cedarvinda
Copy link
Member Author

@magento-engcom-team give me test instance

@magento-engcom-team
Copy link
Contributor

Hi @cedarvinda. Thank you for your request. I'm working on Magento instance for you

@cedarvinda cedarvinda mentioned this pull request Jan 16, 2019
Closed
@magento-engcom-team magento-engcom-team mentioned this pull request Jan 23, 2019
Closed
@magento-engcom-team magento-engcom-team merged commit 8f4942a into magento:2.3-develop Jan 23, 2019
@ghost
Copy link

ghost commented Jan 23, 2019

Hi @cedarvinda, thank you for your contribution!
Please, complete Contribution Survey, it will take less than a minute.
Your feedback will help us to improve contribution process.

magento-engcom-team pushed a commit that referenced this pull request Jan 23, 2019
@sidolov
ENGCOM-3847: Issue fixed #19985 Send email confirmation popup close b…
df3ca68 
…utton area ov… #19986
@magento-engcom-team
Copy link
Contributor

Hi @cedarvinda. Thank you for your contribution.
We will aim to release these changes as part of 2.3.1.
Please check the release notes for final confirmation.

@irajneeshgupta irajneeshgupta mentioned this pull request Jan 23, 2019
Merged
4 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@VladimirZaets VladimirZaets VladimirZaets left review comments

@nuzil nuzil nuzil approved these changes

Assignees

@nuzil nuzil

Labels
Area: Design/Frontend Award: bug fix Progress: accept Release Line: 2.3
Projects
None yet
Milestone
Release: 2.3.1
Development

Successfully merging this pull request may close these issues.

Send email confirmation popup close button area overlapping to content
4 participants
@cedarvinda @magento-engcom-team @nuzil @VladimirZaets