Fix broken widget placeholders after upgrading from 2.2

[vovayatsyuk]

Affects backend editor when WYSIWYG is enabled and widget declarations are from Magento < 2.3.

Description (*)

This PR makes two things:

1. Makes visible widget placeholder when type_name is not available in widget declaration
2. Makes visible widget name when type_name is not available in widget declaration

Manual testing scenarios (*)

1. Navigate to Content > Pages and create a new page

2. Disable WYSIWYG editor

3. Fill content field with following value (It's a widget code from Magento < 2.3):

   <div>{{widget type="Magento\CatalogWidget\Block\Product\ProductsList" show_pager="0" products_count="10" template="Magento_CatalogWidget::product/widget/content/grid.phtml" }}</div>
   

4. Enable WYSIWYG editor

5. You will see an error icon instead of widget image

Without patch	With patch

Contribution checklist (*)

• Pull request has a meaningful description of its purpose
• All commits are accompanied by meaningful commit messages
• All new or changed code is covered with unit/integration tests (if applicable)
• All automated tests passed successfully (all builds on Travis CI are green)

[magento-engcom-team]

Hi @vovayatsyuk. Thank you for your contribution
Here is some useful tips how you can test your changes using Magento test environment.
Add the comment under your pull request to deploy test or vanilla Magento instance:

• @magento-engcom-team give me test instance - deploy test instance based on PR changes
• @magento-engcom-team give me 2.3-develop instance - deploy vanilla Magento instance

For more details, please, review the Magento Contributor Assistant documentation

[orlangur]

@vovayatsyuk old widget declarations should be migrated automatically during upgrade, isn't it?

[vovayatsyuk]

@orlangur oops, didn't test it, I just copy-paste a widget from third-party instructions :)

However, I still think that the code introduced in 2.3 should be improved to be compatible with 2.2 when it's possible.

Additionally, adding a new internal property ("type_name") is not a good solution because it doesn't work well for multiple backend users with different locales.

p.s. We already have a "type" in widget declaration and it's enough to do the rest of work, why pollute widget declaration with new variables?

[vovayatsyuk]

Just checked updated store (2.2 to 2.3). Standard widget wasn't updated in store homepage:

{{widget type="Magento\Catalog\Block\Product\Widget\NewWidget" display_type="new_products" products_count="8" template="product/widget/new/content/new_grid.phtml"}}

[orlangur]

Considering e4f6d5b#diff-7f5941d4c18c5f77dbccea6c32c5e6b5, @danmooney2 @irenelagno could you please evaluate this suggestion?

[orlangur]

Ping @danmooney2 @irenelagno.

@melnikovi would appreciate your help as you seem to own Widget module.

[danmooney2]

This looks fine. Ideally type_name should be retained as a fallback for the sake of providing feedback when a type is uninstalled, skipped, etc.

[magento-engcom-team]

Hi @orlangur, thank you for the review.
ENGCOM-4584 has been created to process this Pull Request

[VasylShvorak]

✔️ QA passed

[m2-assistant]

Hi @vovayatsyuk, thank you for your contribution!
Please, complete Contribution Survey, it will take less than a minute.
Your feedback will help us to improve contribution process.