Skip to content

Conversation

amritms
Copy link
Member

@amritms amritms commented Dec 30, 2018

removes extra dot on "How to run Magento"

While following the steps in readme file, I encountered a error (extra dot) in "How to run Magento" section. This PR removes that extra dot.

Description (*)

This change reduces the number of errors in documentation/readme files.

Fixed Issues (if relevant)

Manual testing scenarios (*)

This only removes an extra dot in php run magento command. I have manually tested on my local machine.

Contribution checklist (*)

  • Pull request has a meaningful description of its purpose
  • All commits are accompanied by meaningful commit messages
  • All new or changed code is covered with unit/integration tests (if applicable)
  • All automated tests passed successfully (all builds on Travis CI are green)

removes extra dot on "How to run Magento"
removes extra dot on "How to run Magento" in phpserve/README.md
@magento-cicd2
Copy link
Contributor

magento-cicd2 commented Dec 30, 2018

CLA assistant check
All committers have signed the CLA.

@magento-engcom-team
Copy link
Contributor

Hi @amritms. Thank you for your contribution
Here is some useful tips how you can test your changes using Magento test environment.
Add the comment under your pull request to deploy test or vanilla Magento instance:

  • @magento-engcom-team give me test instance - deploy test instance based on PR changes
  • @magento-engcom-team give me 2.3-develop instance - deploy vanilla Magento instance

For more details, please, review the Magento Contributor Assistant documentation

@VladimirZaets
Copy link
Contributor

Hi @amritms , please, sign CLA, otherwise, we can't process your pull request

@amritms
Copy link
Member Author

amritms commented Jan 13, 2019

@VladimirZaets why do i get fail in travis-ci test. I have only changed the docs.
filed test

@DanielRuf
Copy link
Contributor

@VladimirZaets why do i get fail in travis-ci test. I have only changed the docs.

Probably just a flaky test. Try to rebase to get the latest from 2.3-develop.

@DanielRuf
Copy link
Contributor

Don't add another space.
Just do git commit --allow-empty -m 'Trigger new build'

@DanielRuf
Copy link
Contributor

I have restarted the failing job.

@DanielRuf
Copy link
Contributor

Please revert the last change.

@amritms
Copy link
Member Author

amritms commented Jan 14, 2019

@DanielRuf All checks have passed, could you merge this PR

@DanielRuf
Copy link
Contributor

Please wait until the maintainers merge it. I'm just one of many contributors.

@VladimirZaets
Copy link
Contributor

Hi @amritms. Thanks for the collaboration. We already take your PR in progress.

@magento-engcom-team magento-engcom-team added this to the Release: 2.3.1 milestone Jan 17, 2019
@magento-engcom-team
Copy link
Contributor

Hi @VladimirZaets, thank you for the review.
ENGCOM-3905 has been created to process this Pull Request

@magento-engcom-team
Copy link
Contributor

@amritms thank you for contributing. Please accept Community Contributors team invitation here to gain extended permissions for this repository.

@magento-engcom-team magento-engcom-team merged commit 233391b into magento:2.3-develop Jan 23, 2019
@ghost
Copy link

ghost commented Jan 23, 2019

Hi @amritms, thank you for your contribution!
Please, complete Contribution Survey, it will take less than a minute.
Your feedback will help us to improve contribution process.

@magento-engcom-team
Copy link
Contributor

Hi @amritms. Thank you for your contribution.
We will aim to release these changes as part of 2.3.1.
Please check the release notes for final confirmation.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants