Skip to content

Conversation

shikhamis11
Copy link
Member

Fixed Incorrect position of grid header Design Configuration Grid #20024

Preconditions (*)

  1. Magento 2.3

Steps to reproduce (*)

  1. Open the Design Configuration Grid: Content -> Design -> Configuration

Expected result (*)

  1. The grid header is displayed above the grid.
    screen shot 2018-12-31 at 10 18 51 am

Actual result (*)

  1. The grid header is displayed below the grid.
    screen shot 2018-12-31 at 10 17 12 am

Contribution checklist (*)

  • Pull request has a meaningful description of its purpose
  • All commits are accompanied by meaningful commit messages
  • All new or changed code is covered with unit/integration tests (if applicable)
  • All automated tests passed successfully (all builds on Travis CI are green)

@magento-engcom-team
Copy link
Contributor

Hi @shikhamis11. Thank you for your contribution
Here is some useful tips how you can test your changes using Magento test environment.
Add the comment under your pull request to deploy test or vanilla Magento instance:

  • @magento-engcom-team give me test instance - deploy test instance based on PR changes
  • @magento-engcom-team give me 2.3-develop instance - deploy vanilla Magento instance

For more details, please, review the Magento Contributor Assistant documentation

@davidverholen
Copy link
Member

@magento-engcom-team give me test instance

@magento-engcom-team
Copy link
Contributor

Hi @davidverholen. Thank you for your request. I'm working on Magento instance for you

@magento-engcom-team
Copy link
Contributor

Hi @davidverholen, here is your new Magento instance.
Admin access: https://pr-20072.instances.magento-community.engineering/admin
Login: admin Password: 123123q

@magento-engcom-team magento-engcom-team added this to the Release: 2.3.1 milestone Jan 5, 2019
@magento-engcom-team
Copy link
Contributor

Hi @davidverholen, thank you for the review.
ENGCOM-3792 has been created to process this Pull Request

@magento-engcom-team magento-engcom-team merged commit de744ed into magento:2.3-develop Jan 14, 2019
@ghost
Copy link

ghost commented Jan 14, 2019

Hi @shikhamis11, thank you for your contribution!
Please, complete Contribution Survey, it will take less than a minute.
Your feedback will help us to improve contribution process.

@magento-engcom-team
Copy link
Contributor

Hi @shikhamis11. Thank you for your contribution.
We will aim to release these changes as part of 2.3.1.
Please check the release notes for final confirmation.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants