Reverting javascript translation refactoring which broke javascript translation

[mfickers]

Description

This reverts commit 459ce25.

The commit broke some javascript translations, because after javascript translation initialisation was refactored into its own file, the translation dictionary was not initialised early enough.

Fixed Issues (if relevant)

1. Javascript translation issue on modal buttons when removing items from product compare page #19705: Javascript translation issue on modal buttons when removing items from product compare page

Manual testing scenarios (*)

1. Create a translation dictionary file for a storefront language
2. Translate the phrase "Cancel" in the dictionary file
3. Clear cache, deploy static content, ...
4. Click on the remove product link in minicart
5. Observe wether the cancel-button of the confirmation-popup is translated

Contribution checklist (*)

• Pull request has a meaningful description of its purpose
• All commits are accompanied by meaningful commit messages
• All new or changed code is covered with unit/integration tests (if applicable)
• All automated tests passed successfully (all builds on Travis CI are green)

[magento-engcom-team]

Hi @mfickers. Thank you for your contribution
Here is some useful tips how you can test your changes using Magento test environment.
Add the comment under your pull request to deploy test or vanilla Magento instance:

• @magento-engcom-team give me test instance - deploy test instance based on PR changes
• @magento-engcom-team give me 2.3-develop instance - deploy vanilla Magento instance

For more details, please, review the Magento Contributor Assistant documentation

[magento-cicd2]

All committers have signed the CLA.

[sivaschenko]

Hi @mfickers , thanks for the contribution! I would prefer to keep the refactored approach. Maybe there is a way to fix the issue by i.e. introducing dependency that will allow the translation dictionary to be initialised early enough?

[DrewML]

Was the original PR that moved this code into an external file fixing a bug, or just an improvement? If it was just an improvement I'm in favor of a reverting for now and we can try the improvement again with some more testing later.

[magento-engcom-team]

Hi @VladimirZaets, thank you for the review.
ENGCOM-4073 has been created to process this Pull Request

[magento-engcom-team]

@mfickers thank you for contributing. Please accept Community Contributors team invitation here to gain extended permissions for this repository.

[ghost]

Hi @mfickers, thank you for your contribution!
Please, complete Contribution Survey, it will take less than a minute.
Your feedback will help us to improve contribution process.