Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixed apply discount button alignment on checkout page #20144

Merged
merged 3 commits into from Jan 31, 2019
Merged

Fixed apply discount button alignment on checkout page #20144

merged 3 commits into from Jan 31, 2019

Conversation

cedarvinda
Copy link
Member

iessue fixed #20137 On checkout page apply discount button is not align with input box

Description (*)

On checkout page apply discount button is not align with input box

Manual testing scenarios (*)

  1. add product to cart
  2. and go to checkout page

Contribution checklist (*)

  • Pull request has a meaningful description of its purpose
  • All commits are accompanied by meaningful commit messages
  • All new or changed code is covered with unit/integration tests (if applicable)
  • All automated tests passed successfully (all builds on Travis CI are green)

…gn with input box

iessue fixed #20137 On checkout page apply discount button is not align with input box
@magento-engcom-team
Copy link
Contributor

Hi @cedarvinda. Thank you for your contribution
Here is some useful tips how you can test your changes using Magento test environment.
Add the comment under your pull request to deploy test or vanilla Magento instance:

  • @magento-engcom-team give me test instance - deploy test instance based on PR changes
  • @magento-engcom-team give me 2.3-develop instance - deploy vanilla Magento instance

For more details, please, review the Magento Contributor Assistant documentation

@cedarvinda
Copy link
Member Author

@miguelbalparda can you please review this solution ?

@sivaschenko sivaschenko changed the title iessue fixed #20137 On checkout page apply discount button is not ali… Fixed apply discount button alignment on checkout page Jan 10, 2019
@sivaschenko sivaschenko self-assigned this Jan 10, 2019
@magento-engcom-team magento-engcom-team added this to the Release: 2.3.1 milestone Jan 10, 2019
@magento-engcom-team
Copy link
Contributor

Hi @sivaschenko, thank you for the review.
ENGCOM-3818 has been created to process this Pull Request

@sivaschenko
Copy link
Member

@magento-engcom-team give me test instance

@magento-engcom-team
Copy link
Contributor

Hi @sivaschenko. Thank you for your request. I'm working on Magento instance for you

@magento-engcom-team
Copy link
Contributor

Hi @sivaschenko, here is your new Magento instance.
Admin access: https://pr-20144.instances.magento-community.engineering/admin
Login: admin Password: 123123q

@sivaschenko
Copy link
Member

Hi @cedarvinda , thanks for the pull request, however, it does not solve the issue, the button is still not aligned with an input:
image

_payment-options.less updated
@cedarvinda
Copy link
Member Author

@sivaschenko now please review this.

@sivaschenko
Copy link
Member

@magento-engcom-team give me test instance

@magento-engcom-team
Copy link
Contributor

Hi @sivaschenko. Thank you for your request. I'm working on Magento instance for you

@magento-engcom-team
Copy link
Contributor

Hi @sivaschenko, here is your new Magento instance.
Admin access: https://pr-20144.instances.magento-community.engineering/admin
Login: admin Password: 123123q

@magento-engcom-team
Copy link
Contributor

Hi @sivaschenko. Thank you for your request. I'm working on Magento instance for you

@magento-engcom-team
Copy link
Contributor

Hi @sivaschenko, here is your new Magento instance.
Admin access: https://pr-20144.instances.magento-community.engineering/admin
Login: admin Password: 123123q

@sivaschenko
Copy link
Member

Thank you @cedarvinda

@ghost
Copy link

ghost commented Jan 31, 2019

Hi @cedarvinda, thank you for your contribution!
Please, complete Contribution Survey, it will take less than a minute.
Your feedback will help us to improve contribution process.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

On checkout page apply discount button is not align with input box
4 participants