Skip to content

Conversation

priti2jcommerce
Copy link
Contributor

Description (*)

Fixed Issues (if relevant)

  1. Confirmation pop-up at mobile view not proper #20176 : Confirmation pop-up at mobile view not proper

Manual testing scenarios (*)

  1. Add product into cart
  2. remove product from minicart
  3. pop-up not showing proper at mobile view

Contribution checklist (*)

  • Pull request has a meaningful description of its purpose
  • All commits are accompanied by meaningful commit messages
  • All new or changed code is covered with unit/integration tests (if applicable)
  • All automated tests passed successfully (all builds on Travis CI are green)

@magento-engcom-team
Copy link
Contributor

Hi @priti2jcommerce. Thank you for your contribution
Here is some useful tips how you can test your changes using Magento test environment.
Add the comment under your pull request to deploy test or vanilla Magento instance:

  • @magento-engcom-team give me test instance - deploy test instance based on PR changes
  • @magento-engcom-team give me 2.3-develop instance - deploy vanilla Magento instance

For more details, please, review the Magento Contributor Assistant documentation

@priti2jcommerce priti2jcommerce self-assigned this Jan 11, 2019
@magento magento deleted a comment from irajneeshgupta Jan 22, 2019
@priti2jcommerce priti2jcommerce requested review from rogyar and removed request for hryvinskyi January 23, 2019 10:27
@priti2jcommerce priti2jcommerce removed their assignment Jan 23, 2019
@rogyar
Copy link
Contributor

rogyar commented Jan 24, 2019

@magento-engcom-team give me test instance

@magento-engcom-team
Copy link
Contributor

Hi @rogyar. Thank you for your request. I'm working on Magento instance for you

@magento-engcom-team
Copy link
Contributor

Hi @rogyar, here is your new Magento instance.
Admin access: https://pr-20196.instances.magento-community.engineering/admin
Login: admin Password: 123123q

@rogyar rogyar self-assigned this Jan 24, 2019
@magento-engcom-team magento-engcom-team added this to the Release: 2.3.1 milestone Jan 24, 2019
@magento-engcom-team
Copy link
Contributor

Hi @rogyar, thank you for the review.
ENGCOM-3966 has been created to process this Pull Request

@ghost
Copy link

ghost commented Jan 29, 2019

Hi @priti2jcommerce, thank you for your contribution!
Please, complete Contribution Survey, it will take less than a minute.
Your feedback will help us to improve contribution process.

@magento-engcom-team
Copy link
Contributor

Hi @priti2jcommerce. Thank you for your contribution.
We will aim to release these changes as part of 2.3.1.
Please check the release notes for final confirmation.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants