Fix Model\Widget#getConfigAsObject losing it's type declaration #20770
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description (*)
Fix an issue where the
getConfigAsObject()
method loses it's type declaration. This causes issues for any class that extends the Model class and requires it in theprepareWidgetParameters
method.Due to the order of the data calls the setType call (which is a magic setData('type') method) will be overwritten by the following setData call.
Manual testing scenarios (*)
Magento\Widget\Model\Widget
<preference for="Magento\Widget\Model\Widget" type="Your\New\Model" />
prepareWidgetParameters(DataObject $object)
$object->getType()
, the result will be null instead of the Widget typeAfter this PR it will return the class of the Widget in question.
Contribution checklist (*)